Repository navigation
Conversation
sbernauer
approved these changes
Oct 22, 2026
sbernauer
left a comment
Member
There was a problem hiding this comment.
LGTM, but stackabletech/commons-operator#462 also has a changelog entry, which is missing here.
I think we should also set readOnlyRootFilesystem on commons-operator
Member
Author
|
Yes, commons-operator will get a followup to have the And changelog: Good catch. I'll add it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#903
Sets a restricted security context on the operator Deployment (
runAsNonRoot, theRuntimeDefaultseccomp profile,allowPrivilegeEscalation: false, all capabilities dropped) plus a read-only root filesystem, and updates the defaults invalues.schema.jsonto match.The security context is the same one I already did for commons-operator: stackabletech/commons-operator#462
It was approved over there already and more details linked there. Not repeating all of that here.
The read-only root filesystem works because file logs are the only thing an operator writes, and those moved to an
emptyDirunder/var/logwith stackabletech/operator-templating#656.Users can still override all of this.
Note
When this is merged I'll have CLaude open all the remaining ones.
Definition of Done Checklist
Author
Reviewer
Acceptance