Add support for RSA SHA-2 public key algorithms - #1177
Conversation
|
@Rob-Hague I've pushed some changes to this PR. Can you review this? |
|
Thanks! I should have paid more attention to |
|
Thanks to removing PubkeyAcceptedAlgorithms from the config file we know that SSH.NET supports the latest version of OpenSSH without any hack (configuration). |
| /// Initializes a new instance of the <see cref="RsaDigitalSignature"/> class with the SHA-1 hash algorithm. | ||
| /// </summary> | ||
| /// <param name="rsaKey">The RSA key.</param> | ||
| public RsaDigitalSignature(RsaKey rsaKey) |
There was a problem hiding this comment.
how about adding [Obsolete("Comment")] and using always new constructor?
There was a problem hiding this comment.
I do not think it is necessary here
(but I don't mind)
|
It looks that everything is ready. I have to look over |
WojciechNagorski
left a comment
There was a problem hiding this comment.
Great work! Without you, we definitely wouldn't have rsa-sha-256 and rsa-sha-512 in this release. I'm merging this PR as is, but I will change the approach for IHostAlgorithmsProvide in the next PR. I've done many tests and experiments and it turned out that this was not the best approach.
See #1174 and RFC 8332 for details.
closes #1174
closes #1145
closes #1116
closes #1105
closes #956
closes #825
It may also close the following:
#1141
#1025
#1003
#858
#845