To check if batch is closed if you need to return a pointer to the type the wrong code is generated

[flymedllva]

Version

v1.16.0 or 3623ec8, version v1.15.0 has the correct behavior, since there is no batch closeness check

What happened?

To check if batch is closed if you need to return a pointer to the type the wrong code is generated

SQL queries

:batchone

Configuration

version: "2"
engine: "postgresql"
sql_package: "pgx/v4"
emit_db_tags: true
emit_result_struct_pointers: true

What operating system are you using?

macOS

What database engines are you using?

PostgreSQL

What type of code are you generating?

Go

[JordanP]

Nothing really wrong in the original PR, it's just that the emit_result_struct_pointers feature flag did not exist when the PGXv5 support was originally submitted.

[JordanP]

It certainly is a regression though,it probably means we moved "old" code to a new place.

[flymedllva]

This flag was also for v4. Generally, with this flag there is an error in codogeneration

[thesiti92]

would be great to merge this :)