Repository navigation
Conversation
Per the WHATWG HTML Living Standard, a line without a colon is a field name with an empty value. Treat bare "data", "id", "event", and "retry" the same as the colon form with an empty value. Fixes spring-projectsgh-37461 Signed-off-by: lejuho <zedd1324@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: web
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #37461.
ServerSentEventHttpMessageReaderonly recognized SSE field lines that contain a colon (data:,id:,event:,retry:). Per the WHATWG HTML Living Standard, a line without a colon is a field name with an empty value, sodataanddata:(and likewise forid,event, andretry) must be treated equivalently.Changes
data,id,event, andretrylines as the corresponding field with an empty value.retrywithout a colon is ignored, consistent with the existing invalid-retry handling.Testing
Result: BUILD SUCCESSFUL (15 tests, 0 failures; Checkstyle passes).