Repository navigation
Discard further rows once maxRows has been reached - #34709
Merged
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
type: enhancement
See spring-projects#34666 (comment) Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
jhoeller
added a commit
that referenced
this pull request
Jul 7, 2025
noojung
added a commit
to noojung/spring-framework
that referenced
this pull request
Oct 8, 2026
JDBC defines a maxRows value of zero as unlimited. The client-side row limiting introduced in spring-projectsgh-34709 instead treats it as a limit of zero, discarding all rows when processing results through a RowMapper, RowCallbackHandler, or Stream. Apply client-side limits only for positive maxRows values. See spring-projectsgh-34709 Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #34666 (comment)