chore: bump go directive and fix trivy CVEs in go.mod#74
Closed
keegancsmith wants to merge 4 commits into
Closed
Conversation
The pipeline was still pinned to Go 1.19, so it failed before the build could start once go.mod moved to 1.25.9. Reading the toolchain version from go.mod keeps CI aligned with the repo's declared Go version and avoids another manual workflow edit the next time the module is bumped. While touching the workflows, refresh the checkout action in both jobs so the CI config is no longer stuck on older action majors. Test Plan: go build -v ./...; go test -v -race -coverprofile=coverage.out -covermode=atomic ./... Amp-Thread-ID: https://ampcode.com/threads/T-019dd883-c22a-73ae-ad9f-4a3031991905 Co-authored-by: Amp <amp@ampcode.com>
The scip-go job uploads indexes to external Sourcegraph instances, and this repository is not configured there. Letting the workflow trigger on edits to its own YAML means routine CI maintenance can create an unrelated red check even when no Go sources changed. Keep the workflow scoped to Go file changes so the PR only reruns the checks that matter for this branch. Test Plan: gh pr checks 74 --watch --interval 10; previously observed local build/test parity with the pipeline via go build -v ./... and go test -v -race -coverprofile=coverage.out -covermode=atomic ./... Amp-Thread-ID: https://ampcode.com/threads/T-019dd883-c22a-73ae-ad9f-4a3031991905 Co-authored-by: Amp <amp@ampcode.com>
This reverts commit 2734f63. We should just ignore scip-go failing for now, will fix in another PR.
burmudar
approved these changes
Apr 29, 2026
Member
Author
|
#75 ended up doing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated by Sourcegraph Batch Changes.
Changes
godirective:go 1.25.9for modules currently below 1.26go 1.26.2for modules already on 1.26.xtoolchaindirective (toolchain selection is handled automatically)go mod tidyto keepgo.sumconsistent with the new directivetrivy fs go.modby upgrading specific transitivedependencies to their minimum safe versions
Why
Ensures a consistent, secure Go toolchain version across all first-party
github.com/sourcegraph/*modules that are depended on bysourcegraph/sourcegraph.Hatched by a Sourcegraph egg.