This repository was archived by the owner on Nov 6, 2018. It is now read-only.
Replace extension drop-downs with toggles - #56
Merged
Conversation
chrismwendt
commented
Oct 5, 2018
chrismwendt
commented
- Toggles instead of dropdowns + buttons
- Hover on the toggle to see where the extension is enabled/disabled
- Still asks for confirmation when enabling an extension that doesn't exist in the settings
- Pulls in @ijsnow's new and improved toggle ✨
BREAKING CHANGE: ExtensionPrimaryActionButton is now called ExtensionToggle
This was referenced Oct 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
+ Coverage 15.92% 16.93% +1%
=======================================
Files 36 35 -1
Lines 1124 1063 -61
Branches 287 274 -13
=======================================
+ Hits 179 180 +1
+ Misses 945 883 -62
Continue to review full report at Codecov.
|
Author
|
I don't feel that the lack of client-side prediction is too janky, and I don't want to risk introducing any bugs at the moment, so I'm merging this as-is. |
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.