fix(session): classify ReadableStream locked as retryable and add stream trace types#16
Merged
Conversation
…eam trace types - Extend OPENAI_TRANSIENT_PATTERNS with ReadableStream locked / Invalid state / ERR_INVALID_STATE patterns - Check APICallError cause chain in isOpenAiGatewayTransient so stream-level TypeErrors buried in cause are classified as retryable - Add fromError path for raw Error/TypeError with ReadableStream locked → retryable APIError 'Provider stream connection lost' - Add StreamTrace type (session/stream-log.ts) for structured stream lifecycle observability — types only, integration in next WAVE - Tests: +3 (error classification ×2, fromError conversion ×1)
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary — WAVE 1 of Continuation Boundary fix
OPENAI_TRANSIENT_PATTERNSwithReadableStream is locked/Invalid state/ERR_INVALID_STATEpatternsAPICallErrorcause chain inisOpenAiGatewayTransientso stream-levelTypeErrorburied in cause is classified as retryablefromErrorpath for rawError/TypeErrorwithReadableStream is locked→ retryableAPIError'Provider stream connection lost'StreamTracetype (session/stream-log.ts) for structured stream lifecycle observability — types only, integration planned in WAVE 2Tests +43 pass, 0 fail — typecheck PASS — build PASS
Next: WAVE 2 (core stream boundary redesign) — brief at
hatch-v3/briefs/BRIEF_CONTINUATION_BOUNDARY_WAVE2-3.md