Utilize Devise location helpers for redirecting#228
Merged
waiting-for-dev merged 3 commits intosolidusio:masterfrom Sep 16, 2022
Merged
Conversation
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
fe55762 to
105c85e
Compare
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
2 times, most recently
from
1c3014e to
af35dc9
Compare
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
3 times, most recently
from
af35dc9 to
78a8135
Compare
6 tasks
cpfergus1
changed the title
cpfergus1
changed the title
With the deprecation of #redirect_back_or_default in solidus 4.0, we can utilize Devise helpers store_location_for and stored_location_for to provide the same functionality. Co-Authored-By: Elia Schito <elia@schito.me>
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
78a8135 to
22bd2ce
Compare
This was referenced Sep 13, 2022
This method was utilized for redirect_back_or_default. It is no longer required
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
606dfd6 to
51741d5
Compare
kennyadsl
approved these changes
Sep 15, 2022
adammathys
approved these changes
Sep 15, 2022
waiting-for-dev
approved these changes
Sep 16, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes #redirect_back_or_default in favor of new simplified methods utilizing Devise helpers
store_location_forandstored_location_forMotivation and Context
The method #redirect_back_or_default and the class user_last_url_storer will be deprecated in Solidus PR #4533 which would break the current build without these changes. Because Devise already provides functionality similar to redirect_back_or_default, the included functions will be utilized by other extensions dependent on solidus_auth_devise
How Has This Been Tested?
The current test suite covers the changes made in the PR
Types of changes
Bug fix (non-breaking change which fixes an issue)New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist: