Repository navigation
Conversation
alxbilger
added
pr: status to review
alxbilger
force-pushed
the
basevectorstate
branch
from
November 6, 2026 16:10
4f7a6e3 to
c963f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the content of the class, there is no reason that
BaseMechanicalStaterequires to be named after mechanics. It is more an interface for the manipulation of vectors. That is why I suggest to rename itBaseVectorState.This PR keeps the symbol
BaseMechanicalStateas an alias toBaseVectorState. I did not add the deprecation of the symbol and the header. It will come in another PR, when this one is validated.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if