Skip to content

[AnimationLoop] Replace endIntegration with resetVec - #6440

Open
alxbilger wants to merge 1 commit into
sofa-framework:masterfrom
alxbilger:animloopresetvec
Open

alxbilger wants to merge 1 commit into
sofa-framework:masterfrom
alxbilger:animloopresetvec

Conversation

@alxbilger

@alxbilger alxbilger commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

In the known implementations of BaseMechanicalState::endIntegration, we clear the vector with id externalForce. Instead of having a specific method endIntegration, this PR suggests to simply call resetVec instead. If we do that, endIntegration becomes dead and can be deprecated.

Related to #6362

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant