Repository navigation
Conversation
fredroy
added
pr: status to review
hugtalbot
removed
the
pr: based on previous PR
- BaseMass: make the deprecated getPotentialEnergy(mparams) overload non-virtual (it was final) so Mass<T> no longer hides it - ImplicitIntegrationScheme: mark integration factor methods override - Remove unused MechanicalGetNonDiagonalMassesCountVisitor includes - MechanicalOperations: silence deprecated-header messages for the PropagateDx visitors it still uses internally
- BaseLink::readFromSnapshot: rename the link value string so the loop variable linkPath no longer hides it (C4456) - ObjectElement::initNode: rename local parent to parentElement so it no longer hides the Element::parent member (C4458)
- CompressedRowSparseMatrixGeneric::compressCSR: wrap the body in if constexpr (Policy::CompressZeros) instead of an early return - FixedArrayTypeInfo::setSize: move the fallback return into an else branch of the if constexpr - BackTrace: remove the dead return after the switch in SigDescription, the default case already returns
- DynamicLibrary: explicitly cast the GetProcAddress result to void* (-Wmicrosoft-cast) - PipeProcess: remove the set-but-unused busy flag in the Windows branch (-Wunused-but-set-variable)
fredroy
force-pushed
the
fix_remaining_warnings_framework
branch
from
November 8, 2026 22:59
d9004f1 to
5686a71
Compare
- BaseForceField, BaseMass: make the deprecated addDForce(mparams, dfId)
and accFromF(mparams, aid) overloads non-virtual (they were final) so
ForceField, Mass, PairInteractionForceField and
MixedInteractionForceField no longer hide them (-Woverloaded-virtual)
- Core config: do not mark beginIntegration as deprecated when building
Sofa.Simulation.Core, whose deprecated
MechanicalBeginIntegrationVisitor still calls it
(-Wdeprecated-declarations)
- MechanicalIntegrationVisitor: silence the deprecated-header message
of MechanicalBeginIntegrationVisitor, which it still uses
- DefaultAnimationLoop: remove the unused
MechanicalBeginIntegrationVisitor include and mark dt as unused
(-Wunused-parameter)
- MechanicalMassLinearSolveVisitor: include its own header instead of
the deprecated MechanicalAccFromFVisitor.h
- Mass overrode the deprecated ForceField::addDForce(mparams, df, dx)
with an empty body, which triggered C4996 in every module including
Mass.h (e.g. Sofa.Simulation.Core). The base implementation is also
empty, so removing the override keeps the same behavior
fredroy
force-pushed
the
fix_remaining_warnings_framework
branch
from
November 9, 2026 03:18
5686a71 to
ea0a4d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
tested on the 3 systems and in debug
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if