Skip to content

build: drop @types/flat stub since flat@6 ships with types included - #706

Merged
mwbrooks merged 2 commits into
mainfrom
drop-types-flat
Nov 3, 2026
Merged

mwbrooks merged 2 commits into
mainfrom
drop-types-flat

Conversation

@zimeg

@zimeg zimeg commented Nov 3, 2026

Copy link
Copy Markdown
Member

Summary

This pull request drops the @types/flat dev dependency because flat ships its own type definitions.

Requirements

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:patch labels Nov 3, 2026
@zimeg zimeg self-assigned this Nov 3, 2026
@changeset-bot

changeset-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e164723

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (833bbd7) to head (e164723).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines         732      732           
=======================================
  Hits          731      731           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg changed the title build: drop the @types/flat stub since flat ships its own types build: drop @types/flat stub since flat@6 ships with types included Nov 3, 2026
@zimeg
zimeg marked this pull request as ready for review November 3, 2026 04:38
@zimeg
zimeg requested a review from a team as a code owner November 3, 2026 04:38
Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg!

@mwbrooks
mwbrooks merged commit 83ebce6 into main Nov 3, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the drop-types-flat branch November 3, 2026 20:09

This branch was successfully deployed

1 active deployment
staging — e164723b Deployed Nov 3, 2026 by zimeg via Run CLI tests (ubuntu-latest) #364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants