docs(agents): document registering new methods in the coverage test - #1944
Draft
zimeg wants to merge 1 commit into
Draft
docs(agents): document registering new methods in the coverage test#1944zimeg wants to merge 1 commit into
zimeg wants to merge 1 commit into
Conversation
Adding a Web API method requires registering it in tests/slack_sdk_async/web/test_web_client_coverage.py — both in the all_api_methods list and, for methods with required args, a call branch in run_method. A method absent from the list is not exercised even though the suite passes, so document this step alongside the Web API method pattern. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
=======================================
Coverage 84.15% 84.15%
=======================================
Files 118 118
Lines 13446 13446
=======================================
Hits 11315 11315
Misses 2131 2131 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
all_api_methodscoverage-test registration step in AGENTS.md's Web API method guidance — a method absent from that list goes unexercised even though the suite passes. Surfaced while adding the agents.sessions.* / codeChannels.* methods (#1942, #1943).