Skip to content

Pin GitHub Actions workflow step hashes and use minimum permission #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 4 commits into from
May 21, 2025
Merged

Pin GitHub Actions workflow step hashes and use minimum permission #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b58145
Pin GitHub Actions workflow step hashes and use mimimum permission
zimeg May 20, 2025
e70c893
docs: remove a space to confirm permissions of the docs workflow are …
zimeg May 20, 2025
387fb3c
revert: space removal for a more focused set of changes in this pull …
zimeg May 20, 2025
4c04a6b
ci: move actions permissions into the job for fine grained details
zimeg May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/docs-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,26 @@ on:
branches:
- main
paths:
- 'docs/**'
- "docs/**"
push:
branches:
- main
paths:
- 'docs/**'
- "docs/**"
workflow_dispatch:

jobs:
build:
name: Build Docusaurus
runs-on: ubuntu-latest
permissions:
contents: read
Comment on lines +20 to +21
Copy link
Copy Markdown
Member Author

@zimeg zimeg May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 Permissions for the build step are proving alright with just read! This is interesting to me, but makes sense in the context of uploading artifacts to action outputs perhaps?

📚 https://github.com/slackapi/java-slack-sdk/actions/runs/15126115805?pr=1474

Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
- uses: actions/setup-node@v4
persist-credentials: false
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 20
cache: npm
Expand Down Expand Up @@ -82,7 +85,7 @@ jobs:
working-directory: ./docs

- name: Upload Build Artifact
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa # v3.0.1
with:
path: ./docs/build

Expand All @@ -105,4 +108,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5
14 changes: 6 additions & 8 deletions .github/workflows/triage-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,19 @@

name: Close stale issues and PRs

on:
on:
workflow_dispatch:
schedule:
- cron: '0 0 * * 1'

permissions:
issues: write
pull-requests: write
- cron: "0 0 * * 1"

jobs:
stale:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: actions/stale@v9.1.0
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
with:
days-before-issue-stale: 30
days-before-issue-close: 10
Expand All @@ -31,4 +30,3 @@ jobs:
remove-stale-when-updated: true
enable-statistics: true
operations-per-run: 60

40 changes: 22 additions & 18 deletions .github/workflows/unit-tests-jdk-14.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: JDK 14 Build & Tests

on:
push:
branches: [ main ]
branches:
- main
pull_request:

jobs:
Expand All @@ -11,21 +12,24 @@ jobs:
timeout-minutes: 12
strategy:
matrix:
java-version: ['14']

java-version: ["14"]
permissions:
contents: read
steps:
- uses: actions/checkout@v4
Copy link
Copy Markdown
Member Author

@zimeg zimeg May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ Changes unrelated to hashing steps are due to indentation! No change to testing or functionalities otherwise.

- name: Install JDK
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'adopt'
- name: Run all tests
run: |
./scripts/run_no_prep_tests.sh -ci
env:
SKIP_UNSTABLE_TESTS: 1
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Install JDK
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with:
java-version: ${{ matrix.java-version }}
distribution: "adopt"
- name: Run all tests
run: |
./scripts/run_no_prep_tests.sh -ci
env:
SKIP_UNSTABLE_TESTS: 1
- name: Upload coverage to Codecov
uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
with:
token: ${{ secrets.CODECOV_TOKEN }}
32 changes: 18 additions & 14 deletions .github/workflows/unit-tests-jdk-17.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: JDK 17 Build & Tests

on:
push:
branches: [ main ]
branches:
- main
pull_request:

jobs:
Expand All @@ -11,17 +12,20 @@ jobs:
timeout-minutes: 12
strategy:
matrix:
java-version: ['17']

java-version: ["17"]
permissions:
contents: read
steps:
- uses: actions/checkout@v4
- name: Install JDK
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'adopt'
- name: Run all tests
run: |
./scripts/run_no_prep_tests.sh -ci
env:
SKIP_UNSTABLE_TESTS: 1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Install JDK
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with:
java-version: ${{ matrix.java-version }}
distribution: "adopt"
- name: Run all tests
run: |
./scripts/run_no_prep_tests.sh -ci
env:
SKIP_UNSTABLE_TESTS: 1
38 changes: 21 additions & 17 deletions .github/workflows/unit-tests-jdk-8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: JDK 1.8 Build & Tests

on:
push:
branches: [ main ]
branches:
- main
pull_request:

jobs:
Expand All @@ -11,20 +12,23 @@ jobs:
timeout-minutes: 12
strategy:
matrix:
java-version: ['8']

java-version: ["8"]
permissions:
contents: read
steps:
- uses: actions/checkout@v4
- name: Install JDK
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'adopt'
- name: Run all tests
run: |
if [ ${{ matrix.java-version }} == "8" ]; then
export TRAVIS_JDK=openjdk8
fi
./scripts/run_no_prep_tests.sh -ci
env:
SKIP_UNSTABLE_TESTS: 1
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Install JDK
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with:
java-version: ${{ matrix.java-version }}
distribution: "adopt"
- name: Run all tests
run: |
if [ ${{ matrix.java-version }} == "8" ]; then
export TRAVIS_JDK=openjdk8
fi
./scripts/run_no_prep_tests.sh -ci
env:
SKIP_UNSTABLE_TESTS: 1