Skip to content

Add pagination to Web API files_list - #301

Closed
rangerscience wants to merge 2 commits into
slack-ruby:masterfrom
rangerscience:add-pagination-to-files-list
Closed

Add pagination to Web API files_list#301
rangerscience wants to merge 2 commits into
slack-ruby:masterfrom
rangerscience:add-pagination-to-files-list

Conversation

@rangerscience

@rangerscience rangerscience commented Oct 18, 2019

Copy link
Copy Markdown

See: #299

@rangerscience rangerscience mentioned this pull request Oct 18, 2019
Open
@rangerscience

rangerscience commented Oct 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

I didn't see any tests for pagination that I felt like I could adapt to test this code; there's
https://github.com/slack-ruby/slack-ruby-client/blob/2175a0249225a3d88c81d3b90b0d126c220728e7/spec/slack/web/api/endpoints/custom_specs/users_spec.rb#L15-22
but I don't think I can set up something to VCR for this.

@dangerpr-bot

dangerpr-bot commented Oct 18, 2019 •
edited
Loading

Copy link
Copy Markdown
1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code. 
* [#299](https://github.com/slack-ruby/slack-ruby-client/issues/299): files_list does not paginate - [@rangerscience](https://github.com/rangerscience)

Generated by 🚫 danger

dblock
dblock requested changes Oct 18, 2019
View reviewed changes

@dblock dblock left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by a Rake task, and is not the right place to make this change. Please see #299 (comment) for an explanation.

Comment thread CHANGELOG.md
* [#293](https://github.com/slack-ruby/slack-ruby-client/pull/293): Rubocop auto-correct and comprehensive todo - [@jcraigk](https://github.com/jcraigk).
* [#297](https://github.com/slack-ruby/slack-ruby-client/pull/297): Various Rubocop fixes - [@jcraigk](https://github.com/jcraigk).
* [#298](https://github.com/slack-ruby/slack-ruby-client/pull/298): Add `admin.apps`, `admin.app.requests` and `views` endpoints - [@jmanian](https://github.com/jmanian).
* [#299](https://github.com/slack-ruby/slack-ruby-client/issues/299): files_list does not paginate - [@rangerscience](https://github.com/rangerscience)

@dblock dblock Oct 18, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danger is complaining that the text doesn't start with a capital letter, so make it "Added pagination support to file_list."

@dblock
dblock force-pushed the master branch 3 times, most recently from 6e32e8f to 0d0514f Compare June 29, 2020 12:45
@dblock

dblock commented Jan 28, 2021

Copy link
Copy Markdown
Collaborator

This API does not paginate like other APIs and takes a page and a count parameter, so it will need a different implementation.

@dblock dblock closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dblock dblock dblock requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rangerscience @dangerpr-bot @dblock