Skip to content

chore(ci): simplify Trigger release workflow - #7905

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
trigger-deploy
Sep 17, 2026
Merged

TheodoreSpeaks merged 2 commits into
stagingfrom
trigger-deploy

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use shared Trigger preparation and promotion jobs for every release environment, passing the selected target and uploaded version between them.
  • Preserve migration and image gates, traffic-cutover verification, and each environment's credential session and polling budgets.
  • Remove the standalone deployment test harness and its CI step.

Type of Change

  • Other: CI simplification

Testing

  • Actionlint and Bash syntax checks pass; no workflow references the removed test file.
  • Repository lint, all 46 audits, block-registry and generated-artifact checks pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (not applicable: the deployment test harness is removed)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 17, 2026 1:11am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks TheodoreSpeaks changed the title chore(ci): unify Trigger preparation and promotion jobs chore(ci): simplify Trigger release workflow Sep 17, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The workflow consolidation appears behaviorally sound, but the loss of its dedicated regression suite is a non-blocking maintainability and release-safety concern.

Findings

  1. P2 Deployment Tests Removed ▶

Summary

This PR consolidates environment-specific Trigger.dev release jobs into shared preparation and promotion jobs while retaining branch-specific targets, AWS credentials, deployment pipelines, and timeout budgets.

  • Selects prod, staging, or preview/dev-sim once during preparation and propagates that target with the deployment version.
  • Keeps image promotion behind the relevant migration, build, and Trigger preparation gates.
  • Verifies ECS traffic cutover before promoting the parked Trigger.dev version.
  • Removes the only automated regression harness for this deployment and release-ordering behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Ref[Push to main, staging, or dev] --> Prepare[Prepare Trigger.dev version]
  Ref --> Migrate[Environment migration]
  Ref --> Build[Environment image build]
  Prepare --> PromoteImages[Promote image tags]
  Migrate --> PromoteImages
  Build --> PromoteImages
  PromoteImages --> Cutover[Verify ECS traffic cutover]
  Prepare --> PromoteTrigger[Promote prepared Trigger.dev version]
  Cutover --> PromoteTrigger
Loading

Reviews (2) · Last reviewed commit: "chore(ci): remove Trigger deployment tes..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread .github/workflows/test-build.yml
@TheodoreSpeaks
TheodoreSpeaks merged commit 6dffde3 into staging Sep 17, 2026
34 of 35 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the trigger-deploy branch September 17, 2026 01:18

This branch was successfully deployed

1 active deployment
Preview — f0daacd3 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant