Skip to content

fix(credential-groups): expose provider emails and align people rows - #7904

Merged
TheodoreSpeaks merged 4 commits into
stagingfrom
codex/credential-discovery-people
Sep 17, 2026
Merged

TheodoreSpeaks merged 4 commits into
stagingfrom
codex/credential-discovery-people

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make provider-only organization account discovery clear in the Credential block. List results include verified provider account emails separately from enrollment emails, with existing pagination, exact-email filtering, and workspace/integration restrictions preserved.
  • Show each person’s email with one horizontal line of connected account badges underneath. Hide disconnected and reconnect-required accounts; allow the badge strip to scroll when space is limited.
  • Compare effective block fields against an isolated snapshot of the base revision. This fixes the SFTP declaration mismatch and covers spreads, local arrays, and derived definitions; missing revisions or failed imports fail the audit.

Type of Change

  • Bug fix

Testing

  • 561 credential and UI tests passed, covering provider access revocation between pages, account-email projection, multiple-account pagination, workflow field validation, and People states. Four snapshot regression tests cover derived fields, historical workspace imports, third-party dependencies, and failure handling.
  • Verified the full audit rejects simulated derived-field removals in Linear, Slack, and SFTP without changing source files.
  • App and auth type checks, repository lint, all 46 audits, block-registry validation, and docs manifest check passed.
  • Verified the real People components in a disposable browser fixture at 900px and 375px widths, including loading, empty, and error states. All fixture data was synthetic.

UI

People rows use a small avatar aligned with the email, with connected integration badges on one line underneath. Long emails fade within the row, and overflowing badges scroll horizontally with edge fades. People without connected accounts remain available for invitation and access actions.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 17, 2026 2:40am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule failures remain.

Summary

This PR exposes verified provider account emails in paginated organization-account listings, updates People rows to show active account badges beneath each email, and replaces source-pattern registry auditing with evaluation of the effective registry from an isolated base-revision snapshot.

  • Keeps enrollment-email filtering optional for list operations and required for exact find operations.
  • Preserves workspace, provider, pagination, cursor-scope, and active-account restrictions.
  • Separates provider account addresses from invitation addresses in workflow output.
  • Hides revoked and reconnect-required badges while retaining each person and their available actions.
  • Audits spread-based, locally composed, helper-derived, and inherited block fields against historical source.
Diagram
sequenceDiagram
  participant Workflow
  participant Handler as Credential handler
  participant Access as Credential-group use case
  participant Store as Credential store
  Workflow->>Handler: List organization accounts with providers, optional email, cursor
  Handler->>Access: Principal, workspace, filters, page request
  Access->>Access: Recheck workspace and integration access
  Access->>Store: Read active scoped credentials
  Store-->>Access: Enrollment and provider identities
  Access-->>Handler: Credential references and pagination
  Handler-->>Workflow: credentials, emails, count, hasMore, nextCursor
Loading

Reviews (4) · Last reviewed commit: "fix(credential-groups): resolve staging ..."

Comment thread apps/sim/scripts/block-registry-source.ts Outdated
Comment thread apps/sim/ee/credential-groups/components/organization-person-connections.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/scripts/block-registry-source.ts Outdated
Comment thread apps/sim/scripts/block-registry-source.ts Outdated
Comment thread apps/sim/scripts/check-block-registry.ts Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 49fae45 into staging Sep 17, 2026
35 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/credential-discovery-people branch September 17, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant