Skip to content

fix(slack): allow installation before organization setup - #7900

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
codex/slack-install-before-organization
Sep 17, 2026
Merged

TheodoreSpeaks merged 2 commits into
stagingfrom
codex/slack-install-before-organization

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Let installs initiated from Slack finish without a Sim session or organization, then show setup guidance with links to Slack and Sim.
  • Connect the app to an organization later through the existing admin setup. Preserve state-bound OAuth checks and store no credentials for standalone installs.
  • No database changes.

Type of Change

  • Bug fix

Testing

78 focused tests passed across six suites, covering callback validation, session isolation, OAuth exchange, setup guidance rendering, and existing setup. Repository lint, all 46 audits, generated-artifact checks, and the block registry check passed. Typechecking runs in CI; the live installation flow has not been retested with this change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 12:01am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported wording and styling concerns are resolved, and no new actionable issue was identified.

Summary

This PR enables Slack-initiated installation without requiring a Sim session or organization while preserving the existing authenticated, state-bound organization setup flow.

  • Exchanges and validates standalone Slack OAuth grants without retaining credentials or binding an organization.
  • Redirects standalone installs to a public setup-guidance page.
  • Keeps organization-initiated callbacks on the authenticated setup path.
  • Adds callback, OAuth validation, rendering, and session-isolation coverage.
  • Updates Slack setup documentation.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Slack OAuth callback] --> B{Nonempty state?}
  B -->|Yes| C[Require Sim session]
  C --> D[Validate state and complete organization setup]
  D --> E[Redirect to organization Slack settings]
  B -->|No| F[Exchange one-time Slack code]
  F --> G[Validate app, scopes, and workspace]
  G --> H[Discard grant credentials]
  H --> I[Redirect to public setup-guidance page]
Loading

Reviews (2) · Last reviewed commit: "fix(slack): keep installation guidance n..."

Comment thread apps/sim/app/slack-search/install/[teamId]/page.tsx Outdated
Comment thread apps/sim/app/slack-search/install/[teamId]/page.tsx Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 6ea53c0 into staging Sep 17, 2026
37 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/slack-install-before-organization branch September 17, 2026 00:18

This branch was previously deployed

1 inactive deployment
Preview cfd45be0 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant