fix(access-requests): align permission checks and pending request flows by waleedlatif1 · Pull Request #7880 · simstudioai/sim

waleedlatif1 · 2026-09-16T17:45:28Z

Summary

Match permission reads to the active deployment regime and validate stored policy changes against each field's canonical schema.
Discover the selected target before submission and show existing pending requests. Preserve deployment ceilings, stored grants, and Browse access filters.
Render canonical integration names in approval summaries and Before/After details, collapsing equivalent versions with compact, deterministically generated display metadata.
Reuse shared controls and settings recovery states, trim redundant UI copy, and preserve requester/reviewer URL state through login with nuqs.
Refresh the affected member's cached credit limit after approval, close request dialogs when the member limit recovers, and prevent them from reopening when eligibility returns.

Type of Change

Bug fix

Testing

269 focused application tests and 5 generator tests passed across authorization, review, dialog states, query invalidation, login redirects, toolbar, and workspace prefetch. Full repository lint, all 26 workspace type-checks, all 46 audits, block-registry validation, and docs-manifest verification passed. Generated metadata checks also passed under Danish and Swedish locales. Five database integration tests require the dedicated CI database harness and were skipped locally. Visually checked the actual components with local API fixtures, including collapsed/expanded approval spacing, readable names, shared switches, history, settings errors, and permissions refresh messaging.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-16T17:45:31Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 16, 2026 6:41pm UTC

greptile-apps · 2026-09-16T17:48:50Z

Confidence Score: 5/5

The PR appears safe to merge; no actionable regression or outstanding previous finding remains.

Summary

This PR aligns permission reads with the active deployment regime and strengthens access-request discovery, validation, pending-request navigation, cache refreshes, and dialog lifecycle behavior.

Preserves supported access-request URL state through authentication.
Validates policy changes against canonical field schemas and renders canonical integration names.
Adds target-specific discovery before submission and redirects users to existing pending requests.
Keeps request history usable while settings load or fail independently.
Refreshes usage-limit state after approval and closes request dialogs when eligibility recovers.
Makes generated block-name metadata deterministic across runtime locales.

Diagram

sequenceDiagram
    participant U as User
    participant UI as Access Request UI
    participant D as Target Discovery
    participant API as Request API
    participant Q as Permission/Usage Cache

    U->>UI: Open request action
    UI->>D: Discover selected target
    alt Existing pending request
        D-->>UI: pendingRequestId
        UI-->>U: Open existing request
    else Target is requestable
        D-->>UI: Requestable target
        U->>UI: Submit request
        UI->>API: Create access request
    else Access already granted or unavailable
        D-->>UI: Current eligibility
        UI-->>U: Show current state
    end

    API->>Q: Invalidate affected permission/usage data
    Q-->>UI: Refreshed eligibility
    UI-->>U: Close obsolete dialog after recovery

_{Reviews (7) · Last reviewed commit: "fix(access-requests): clear recovered li..."}

cubic-dev-ai

All reported issues were addressed across 13 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-16T17:52:24Z

The import-order finding conflicts with the repository's active formatter configuration. In biome.json, the :PACKAGE: group includes both @sim/emcn and next/navigation, and Biome orders the scoped package first. I tested the suggested order with and without a separating blank line: both fail Biome, and biome check --write restores the exact current source. Full repository lint and CI lint pass with the current order. Keeping the formatter-enforced order avoids a lint regression or an unrelated repository-wide configuration change.

waleedlatif1 · 2026-09-16T17:52:25Z

@greptile

waleedlatif1 · 2026-09-16T17:52:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T17:52:32Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 13 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-16T17:56:21Z

@greptile

waleedlatif1 · 2026-09-16T17:56:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T17:56:30Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 13 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-16T18:14:42Z

@greptile

waleedlatif1 · 2026-09-16T18:14:44Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T18:14:50Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-16T18:24:21Z

@greptile

waleedlatif1 · 2026-09-16T18:24:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T18:24:29Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-16T18:28:52Z

@greptile

waleedlatif1 · 2026-09-16T18:28:53Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T18:29:00Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 31 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

…spacing

waleedlatif1 · 2026-09-16T18:40:30Z

@greptile

waleedlatif1 · 2026-09-16T18:40:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T18:40:37Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 31 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

vercel Bot temporarily deployed to Preview September 16, 2026 17:45 Inactive

waleedlatif1 mentioned this pull request Sep 16, 2026

v0.8.40: browser agent improvements, permission requests #7876

Merged

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread apps/sim/components/access-requests/request-access-action.tsx

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread apps/sim/components/access-requests/request-access-action.tsx

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

waleedlatif1 added 2 commits September 16, 2026 11:11

fix(access-requests): align permission checks and pending request flows

7fd916a

fix(access-requests): align settings and state with shared patterns

e2bf544

waleedlatif1 force-pushed the codex/access-request-review-7876 branch from 55ab2fd to e2bf544 Compare September 16, 2026 18:14

vercel Bot temporarily deployed to Preview September 16, 2026 18:14 Inactive

fix(access-requests): show readable integration policy names

cf41d74

vercel Bot deployed to Preview September 16, 2026 18:25 View deployment

improvement(access-requests): trim redundant interface copy

db8f6d3

vercel Bot temporarily deployed to Preview September 16, 2026 18:28 Inactive

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx

Comment thread scripts/generate-block-successors.ts Outdated

fix(access-requests): clear recovered limit dialogs and align review …

07b3514

…spacing

vercel Bot deployed to Preview September 16, 2026 18:41 View deployment

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

waleedlatif1 merged commit f9ad878 into staging Sep 16, 2026
33 of 34 checks passed

waleedlatif1 deleted the codex/access-request-review-7876 branch September 16, 2026 18:47

Conversation

waleedlatif1 commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

waleedlatif1 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

waleedlatif1 commented Sep 16, 2026 •

edited

Loading

vercel Bot commented Sep 16, 2026 •

edited

Loading

greptile-apps Bot commented Sep 16, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading