Skip to content

fix(credentials): restore scoped Slack bot reconnects - #7879

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
fix/slack-reconnect-custom-bot
Sep 16, 2026
Merged

TheodoreSpeaks merged 2 commits into
stagingfrom
fix/slack-reconnect-custom-bot

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Fix custom Slack bot reconnects by keeping workspace scope in the query instead of the strict update body.
  • Extend the organization update schema with its required scope while preserving validation, and add regression coverage for both reconnect paths.

Type of Change

  • Bug fix

Testing

111 focused credential tests pass. App type-check, cleanup review, lint, API validation, and repository audits pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 16, 2026 5:46pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the scoped request shapes are aligned with their contracts and no outstanding findings remain.

Summary

This PR restores scoped Slack bot reconnect behavior and aligns the organization credential contract with its client request shape.

  • Keeps workspace scope in the workspace update query while excluding it from the strict request body.
  • Requires organization scope in organization credential updates using the shared strict schema.
  • Adds regression coverage for workspace-scoped, personal, and organization-scoped reconnect requests.
  • Adds the required const assertions to the test fixtures, fully addressing the previous resolved finding.

Reviews (2) · Last reviewed commit: "chore(credentials): add const assertions..."

Comment thread apps/sim/hooks/queries/scoped-credentials-mutations.test.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 360d653 into staging Sep 16, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/slack-reconnect-custom-bot branch September 16, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant