Skip to content

fix(sidebar): extend faded labels until row actions appear - #7874

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/sidebar-hover-actions
Sep 16, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/sidebar-hover-actions

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Let faded sidebar labels use the idle action space, revealing options on hover, keyboard focus, or while their menu is open.
  • Apply the same behavior to workspace and organization sidebars, collapsed menus, the workspace switcher, and editor chat history. Preserve status indicators and visible actions on touch devices.
  • Keep menu widths stable and make inline dropdown actions keyboard-accessible without selecting the row.

Type of Change

  • Bug fix

Testing

Tested the running app with long labels, hover, keyboard focus, folder options, open menus, and collapsed navigation. Checked no-hover layouts in a component preview. All 145 focused tests, app type-check, lint, 46 repository audits (including API boundary validation), and generated-file checks pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 16, 2026 3:52am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the changed row-action, menu, and keyboard behaviors remaining consistent across the inspected callers.

Summary

This PR centralizes sidebar row-action reveal behavior and extends the EMCN dropdown-menu item API for stable labels and keyboard-accessible inline actions.

  • Adds a shared SidebarRowActions component for hover, focus, open-menu, and touch states.
  • Applies consistent action and indicator handling across workspace, organization, chat, workflow, and folder rows.
  • Adds keyboard focus transitions and responsive action-space reservation to dropdown-menu items.
  • Migrates editor chat history to the shared dropdown action pattern and adds focused behavioral tests.

Reviews (1) · Last reviewed commit: "fix(sidebar): extend faded labels until ..."

@waleedlatif1
waleedlatif1 merged commit c568401 into staging Sep 16, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/sidebar-hover-actions branch September 16, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant