feat(streaming): support nested workflow outputs - #7346
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR adds invocation-scoped nested-workflow output selection and streaming across chat, API, CLI, Slack, executor, and workflow-authoring surfaces.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.tsx | Adds nested workflow drilldown and a deterministic remount key that resolves the previously reported stale-path crash. |
| apps/sim/lib/workflows/streaming/streaming.test.ts | Expands transformed-stream lifecycle coverage; no blocking behavior issue was identified. |
| apps/sim/lib/workflows/streaming/resolve-output-selectors.ts | Resolves public root and child-workflow selectors into execution-scoped internal output identities. |
| apps/sim/executor/handlers/workflow/workflow-handler.ts | Propagates selected child-workflow outputs and scopes their stream and completion events. |
| apps/sim/lib/webhooks/slack-execution-stream.ts | Combines transformed byte-stream answers with agent-event lifecycle updates for Slack. |
| apps/sim/lib/workflows/streaming/nested-output-options.ts | Builds nested workflow output options and menu paths for selector consumers. |
Sequence Diagram
sequenceDiagram
participant Client
participant Selector as Output selector
participant Root as Root workflow
participant Child as Child workflow
participant Stream as Streaming response
Client->>Selector: Select childWorkflow.block.path
Selector->>Root: Resolve scoped selector
Root->>Child: Execute selected child workflow
Child-->>Root: Stream scoped block events
Root-->>Stream: Forward selected output and completion
Stream-->>Client: Answer, tool, and thinking events
Reviews (5): Last reviewed commit: "fix(cli): align streaming selector help ..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 20 files
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
Collaborator
Author
TheodoreSpeaks
force-pushed
the
feat/streamable-subworkflow
branch
from
September 1, 2026 07:44
dead9d3 to
628f800
Compare
Collaborator
Author
Collaborator
Author
Collaborator
Author
Sg312
added a commit
that referenced
this pull request
Sep 1, 2026
…ector resolution Rebasing onto origin/staging carried staging's lib/copilot work into our renamed lib/mothership files via rename detection; this finishes what the replay left incomplete: - Complete the #7151 port: cancel_workflow_run handler + registration on the mothership executor (types, tests, and catalog entry had already rename-followed in). - pickRunBlockOutputs awaits the now-async resolveOutputIds (#7346 made selector resolution child-workflow-aware) and re-imports isValidUuid. - Slack execution stream + tool-call-lifecycle import getToolDisplayTitle from the mothership tool-display module (#7296 semantics kept). - Resolve leftover conflict markers from the first replay's failed batch checkout (browser-tool hardening #7311, YAML bounds #7319 kept). - Drop the obsolete lib/mothership/tools/server/blocks scan root: the block-metadata tool died in the dead-code sweep; blocks reads flow through the already-guarded v2 blocks routes. - Regenerate OpenAPI, CLI API, and CLI docs from the merged contracts. Claude-Session: https://claude.ai/code/session_01CgaxNAaeD3taGdghbXn17w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Outputsdrilldown for child Workflow blocks.Type of Change
Testing
bun run lintbun run lint:checkbun run type-checkbun run check:audits(40/40)Reviewers should focus on nested selector scoping across execution boundaries, transformed Slack streams combining byte-stream answer text with agent-event tool lifecycle events, and the output-selector drilldown behavior.
Checklist
Screenshots/Videos
Not included; the selector uses the existing Combobox drilldown interaction and is covered by component regression tests.