improvement(ui): standardize overflow text - #7175
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR introduces a shared
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/overflow-text/overflow-text.tsx | Defines the shared overflow-label primitive and correctly remeasures when its rendered content changes. |
| packages/emcn/src/components/tooltip/tooltip.tsx | Adds shared resize and font-event measurement lifecycle with captured-element cleanup. |
| packages/emcn/src/components/overflow-text/overflow-text.test.tsx | Covers changing labels, decorated content, font events, shared observation, and Strict Mode replay. |
| packages/workflow-renderer/src/lib/overflow-span.tsx | Reuses the canonical primitive for plain clipped workflow-renderer text while preserving code-preview handling. |
| apps/sim/app/workspace/[workspaceId]/settings/components/settings-resource-row/settings-resource-row.tsx | Integrates overflow labels with activatable rows while retaining separate trailing controls and accessible descriptions. |
Reviews (11): Last reviewed commit: "fix(ui): harden overflow measurement def..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 63 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic review |
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
Validated the Strict Mode concern before changing the lifecycle. In this React runtime, Strict Mode replays callback refs as well as effects, and the ref callback re-registers the mounted label after cleanup. Added a regression test that renders OverflowText under StrictMode, changes its measured width, dispatches a font loading event, and confirms the fade updates. The test passes without a production-code change, so a lifecycle rewrite would add complexity without fixing a reachable bug. |
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 67 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Follow-up on the Strict Mode review: the regression test confirmed current React callback-ref replay restores registration, but it also highlighted that registration and cleanup were owned by different lifecycles. The shared hook now idempotently registers during effect setup and unregisters the same captured element during cleanup, so effect-only replay is safe without relying on ref replay ordering. The Strict Mode/font regression test and full EMCN suite pass. |
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 67 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Re-trigger cubic
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 67 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Re-trigger cubic
Summary
Type of Change
Testing
Checklist