Skip to content

improvement(ui): standardize overflow text - #7175

Merged
waleedlatif1 merged 11 commits into
stagingfrom
codex/unify-fade-truncation
Aug 27, 2026
Merged

improvement(ui): standardize overflow text#7175
waleedlatif1 merged 11 commits into
stagingfrom
codex/unify-fade-truncation

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • add one shared fade-overflow primitive with a full-value tooltip
  • migrate read-only labels across shared menus, navigation, settings, resources, tables, and workflow UI
  • document the platform rule and preserve explicit exceptions for editable, technical, dense, and multiline content

Type of Change

  • Improvement

Testing

  • 130 EMCN tests and 118 workflow-renderer tests
  • app, EMCN, and workflow-renderer type-checks
  • lint, block registry validation, and all 36 repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 27, 2026 10:39pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR introduces a shared OverflowText primitive and migrates constrained read-only labels across application and workflow surfaces.

  • Centralizes single-line clipping, conditional edge fading, and full-value tooltips.
  • Adds shared resize and font-change measurement infrastructure.
  • Adds regression coverage for content changes, font loading, and Strict Mode lifecycle replay.
  • Documents explicit exceptions for editable, technical, dense, and multiline content.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/emcn/src/components/overflow-text/overflow-text.tsx Defines the shared overflow-label primitive and correctly remeasures when its rendered content changes.
packages/emcn/src/components/tooltip/tooltip.tsx Adds shared resize and font-event measurement lifecycle with captured-element cleanup.
packages/emcn/src/components/overflow-text/overflow-text.test.tsx Covers changing labels, decorated content, font events, shared observation, and Strict Mode replay.
packages/workflow-renderer/src/lib/overflow-span.tsx Reuses the canonical primitive for plain clipped workflow-renderer text while preserving code-preview handling.
apps/sim/app/workspace/[workspaceId]/settings/components/settings-resource-row/settings-resource-row.tsx Integrates overflow labels with activatable rows while retaining separate trailing controls and accessible descriptions.

Reviews (11): Last reviewed commit: "fix(ui): harden overflow measurement def..." | Re-trigger Greptile

Comment thread packages/emcn/src/components/overflow-text/overflow-text.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

Comment thread packages/emcn/src/components/tooltip/tooltip.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/emcn/src/components/dropdown-menu/dropdown-menu.tsx Outdated
Comment thread apps/sim/ee/audit-logs/components/audit-logs.tsx Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/tables/tables.tsx Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/logs/logs.tsx Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/logs/logs.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 63 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/emcn/src/components/overflow-text/overflow-text.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 67 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread packages/emcn/src/components/tooltip/tooltip.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Validated the Strict Mode concern before changing the lifecycle. In this React runtime, Strict Mode replays callback refs as well as effects, and the ref callback re-registers the mounted label after cleanup. Added a regression test that renders OverflowText under StrictMode, changes its measured width, dispatches a font loading event, and confirms the fade updates. The test passes without a production-code change, so a lifecycle rewrite would add complexity without fixing a reachable bug.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 67 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/emcn/src/components/overflow-text/overflow-text.tsx Outdated
Comment thread packages/emcn/src/components/overflow-text/overflow-text.tsx Outdated
Comment thread packages/emcn/src/components/tooltip/tooltip.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Follow-up on the Strict Mode review: the regression test confirmed current React callback-ref replay restores registration, but it also highlighted that registration and cleanup were owned by different lifecycles. The shared hook now idempotently registers during effect setup and unregisters the same captured element during cleanup, so effect-only replay is safe without relying on ref replay ordering. The Strict Mode/font regression test and full EMCN suite pass.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 67 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 67 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 72363b3 into staging Aug 27, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/unify-fade-truncation branch August 27, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant