fix(desktop): harden browser and runtime hygiene - #7152
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cc99802 to
05649b1
Compare
Greptile SummaryThe PR hardens desktop browser, terminal, navigation, persistence, updater, and account-data lifecycle boundaries.
Confidence Score: 5/5The PR appears safe to merge within the scope of the previous lifecycle findings. No blocking failure remains in the previously reported server-switch recovery and mandatory-relaunch paths.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/main/server-window.ts | Server changes now clear deployment-scoped state before committing the origin and retain recovery metadata when post-commit finalization fails. |
| apps/desktop/src/main/index.ts | Mandatory relaunches now wait for active account teardown without allowing teardown failure to strand a committed server switch. |
| apps/desktop/src/main/window.ts | Main and attached child windows bypass ordinary beforeunload prompts during a committed mandatory relaunch. |
| apps/desktop/src/main/account-data-generation.ts | Deployment teardown commits and marker finalization are coordinated without allowing deployment cleanup to clear an active account-wipe marker. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Request[Request server change] --> Marker{Persist recovery marker}
Marker -->|Failure| Abort[Keep current server and report error]
Marker -->|Success| Clear[Clear deployment-scoped state]
Clear -->|State survives| Abort
Clear --> Commit{Commit new origin}
Commit -->|Failure| Abort
Commit -->|Success| Finalize[Finalize recovery marker]
Finalize -->|Success| Relaunch[Mandatory relaunch]
Finalize -->|Failure| Armed[Keep startup recovery armed]
Armed --> Relaunch
Relaunch --> Teardown{Account teardown active}
Teardown -->|Yes| Wait[Wait for teardown]
Wait --> Continue[Continue committed relaunch]
Teardown -->|No| Continue
Continue --> Restart[Start on new origin partition]
Reviews (8): Last reviewed commit: "fix(desktop): make committed relaunch no..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 83 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
05649b1 to
0926849
Compare
b2aed9c to
9d1d7dd
Compare
1 similar comment
f97984c to
f57822b
Compare
Summary
Type of Change
Testing
Validated with the full monorepo test and type-check suites, lint, 36 audits, source Electron E2E, and fresh packaged Electron fuse and launch smoke tests.
Checklist