Skip to content

fix(docker): prune the app package by manifest name - #6736

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/github-ci
Aug 15, 2026
Merged

fix(docker): prune the app package by manifest name#6736
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/github-ci

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Resolve the application package name from its manifest before pruning
  • Prevent the sim CLI from being pruned instead of the application

Type of Change

  • Bug fix

Testing

Cold-cache linux/amd64 Docker dependency build passed

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 15, 2026 7:00pm

Request Review

@cursor

cursor Bot commented Aug 15, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Build-only Dockerfile change with no runtime auth, data, or application logic impact; reduces risk of silently wrong prune targets during image builds.

Overview
The pruner stage no longer calls turbo prune sim --docker with a fixed name. It reads apps/sim/package.json at build time and passes that name to turbo prune.

That matters because packages/sim-cli is also named sim, so the old target could prune the CLI workspace instead of @sim/app after renames or naming collisions—breaking dependency install and the rest of the image pipeline.

A related comment now refers to turbo prune generically instead of turbo prune sim.

Reviewed by Cursor Bugbot for commit 05eb137. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR fixes Docker pruning by resolving the application workspace name from apps/sim/package.json instead of using the colliding sim CLI package name.

  • Reads the application package name during the pruner stage.
  • Passes the resolved @sim/app name to turbo prune.
  • Updates the dependency-stage explanation to avoid referring to the obsolete hard-coded target.

Confidence Score: 5/5

The PR appears safe to merge, with the application package now selected correctly during Docker pruning.

The pruner stage has Bun available, runs from the copied repository root, resolves the existing @sim/app manifest name, and passes it as one quoted argument to Turbo.

Important Files Changed

Filename Overview
docker/app.Dockerfile Correctly resolves and quotes the application manifest name before pruning; no actionable issue was identified.

Reviews (1): Last reviewed commit: "fix(docker): prune the app package by ma..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit e3b428e into staging Aug 15, 2026
20 of 21 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/github-ci branch August 15, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant