fix(snowflake): drop the oversized credential modal help text - #6475
Conversation
The paragraph under the token field ran 313 characters — three times the typical provider's and 50% longer than the next worst — and pushed the account host field down the modal. Its content (expiry, role restriction, the network-policy requirement per user type) already lives on the setup guide the modal links, and the network-policy cause is repeated in the rejection copy, which is when someone actually needs it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview That copy duplicated guidance already in the linked setup guide and in Reviewed by Cursor Bugbot for commit a1ad16c. Configure here. |
Greptile SummaryThis PR removes the oversized Snowflake credential help paragraph while preserving the linked setup guide and provider-specific rejection guidance.
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The optional help text is removed through an already-supported descriptor shape, while the setup-guide link and credential-rejection guidance remain available.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/credentials/token-service-accounts/descriptors.ts | Safely removes optional Snowflake modal help text without changing credential behavior or eliminating access to setup guidance. |
Reviews (1): Last reviewed commit: "fix(snowflake): drop the oversized crede..." | Re-trigger Greptile
Summary
helpTextat all, so this matches the existing range rather than inventing a new one.Type of Change
Testing
Tested manually.
type-check, lint,check:api-validationand the credentials suite all pass; the diff is two deleted lines.Checklist