Skip to content

fix(snowflake): drop the oversized credential modal help text - #6475

Merged
waleedlatif1 merged 1 commit into
stagingfrom
snowflake-credential-modal-copy
Aug 9, 2026
Merged

fix(snowflake): drop the oversized credential modal help text#6475
waleedlatif1 merged 1 commit into
stagingfrom
snowflake-credential-modal-copy

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the help paragraph under the Programmatic access token field in the Snowflake credential modal. It ran 313 characters — 3× the typical provider's and 50% longer than the next worst — and pushed the Account host field down the modal.
  • Everything it said (expiry defaults, role restriction, the network-policy requirement per user type) is already on the setup guide the modal links to, and the network-policy cause is repeated in the rejection copy, which is when someone actually needs it.
  • Three providers already ship no helpText at all, so this matches the existing range rather than inventing a new one.

Type of Change

  • Bug fix

Testing

Tested manually. type-check, lint, check:api-validation and the credentials suite all pass; the diff is two deleted lines.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The paragraph under the token field ran 313 characters — three times the
typical provider's and 50% longer than the next worst — and pushed the account
host field down the modal. Its content (expiry, role restriction, the
network-policy requirement per user type) already lives on the setup guide the
modal links, and the network-policy cause is repeated in the rejection copy,
which is when someone actually needs it.
@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 9, 2026 8:46am

Request Review

@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only metadata change with no auth, validation, or server verification impact.

Overview
Removes the optional helpText on the Snowflake programmatic access token service-account descriptor so the connect modal no longer shows a long caveat under the token field.

That copy duplicated guidance already in the linked setup guide and in invalidCredentialsHelp on failed verification. Snowflake now aligns with other token providers that omit helpText (e.g. ClickUp, Linear, Claude Platform).

Reviewed by Cursor Bugbot for commit a1ad16c. Configure here.

@waleedlatif1
waleedlatif1 merged commit 4475686 into staging Aug 9, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the snowflake-credential-modal-copy branch August 9, 2026 08:48
@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the oversized Snowflake credential help paragraph while preserving the linked setup guide and provider-specific rejection guidance.

  • Removes only the optional Snowflake helpText.
  • Leaves credential fields, validation, documentation link, and error handling unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The optional help text is removed through an already-supported descriptor shape, while the setup-guide link and credential-rejection guidance remain available.

Important Files Changed

Filename Overview
apps/sim/lib/credentials/token-service-accounts/descriptors.ts Safely removes optional Snowflake modal help text without changing credential behavior or eliminating access to setup guidance.

Reviews (1): Last reviewed commit: "fix(snowflake): drop the oversized crede..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant