fix(og): read OG fonts from the repo instead of fetching Google Fonts at build - #6471
Conversation
… at build The release build died prerendering an integration OG card with "No fonts are loaded. At least one font is required to calculate the layout." loadGoogleFont swallowed every failure and returned null, so a throttled fetch produced an empty fonts array, and Satori requires at least one. Six routes build OG images -- integrations/[slug] alone is 237 pages -- and each render fetched two weights subsetted by &text=, a per-page URL no cache can reuse. Several hundred uncacheable requests to one host from one CI egress IP across parallel build workers, so a page losing that race was expected, not unlucky. Mintlify was just whichever page drew the short straw; its description is 56 chars, unremarkable next to slack's 141. Geist 400/500 now ship in public/brand/fonts and are read once at module scope, per Next's ImageResponse guidance. .ttf because Satori accepts only ttf/otf/woff -- the .woff2 already served to browsers cannot be reused. public/ needs no outputFileTracingIncludes entry: the Dockerfile copies it into the runner, which the force-dynamic share-token card needs since it renders per request. Output is unchanged: rendering the same card with the full font and with the old subset produces a byte-identical PNG (0 of 3,024,000 subpixels differ). Render drops from ~74ms plus ~425ms of font fetching to ~74ms, and the share card no longer makes two Google round trips per request.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Adds Geist OFL license text and a Vitest test that renders a real PNG and checks the PNG magic bytes so missing fonts fail loudly at test time. Reviewed by Cursor Bugbot for commit 6ba48b8. Configure here. |
Greptile SummaryThe PR replaces per-render Google Fonts requests for OG images with repository-bundled Geist fonts loaded once at module initialization.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/(landing)/og-utils.tsx | Replaces fallible remote font fetching with deterministic module-scope reads of bundled Geist fonts. |
| apps/sim/app/(landing)/og-utils.test.tsx | Exercises the real OG renderer and verifies that it returns a nontrivial PNG. |
| apps/sim/public/brand/fonts/Geist-Regular.ttf | Adds the bundled Geist regular font used by the OG renderer. |
| apps/sim/public/brand/fonts/Geist-Medium.ttf | Adds the bundled Geist medium font used by the OG renderer. |
| apps/sim/public/brand/fonts/Geist-OFL.txt | Adds the license accompanying the bundled Geist font files. |
Reviews (2): Last reviewed commit: "docs(og): record why process.cwd() is th..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Review flagged the font path as invalid in the standalone image, reasoning that the container starts at the monorepo root. It does -- but Next's generated standalone server.js opens with process.chdir(__dirname), and that file ships beside public/. Same reason content/ is read this way at runtime.
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6ba48b8. Configure here.
1 participant
Summary
No fonts are loaded. At least one font is required to calculate the layout.loadGoogleFontswallowed every failure and returnednull, so a throttled fetch produced an emptyfontsarray — and Satori requires at least one.integrations/[slug]alone is 237 pages), and each render fetched two weights subsetted by&text=— a per-page URL no cache can reuse. Several hundred uncacheable requests to one host from one CI egress IP across parallel build workers, so a page losing that race was expected, not unlucky. Mintlify was just whichever page drew the short straw — its description is 56 chars, unremarkable next to slack's 141.public/brand/fontsand are read once at module scope, per Next's ImageResponse guidance..ttfbecause Satori accepts only ttf/otf/woff — the.woff2already served to browsers cannot be reused here.public/needs nooutputFileTracingIncludesentry:docker/app.Dockerfilecopies it into the runner, which theforce-dynamicshare-token card needs since it renders per request.Output is unchanged
Rendered the same card with the full font and with the old Google subset and diffed the pixels:
Performance
force-dynamic)Font cost is 146 KB for both weights, against
ImageResponse's 500 KB budget.Type of Change
Testing
Added
og-utils.test.tsx, which renders a real PNG and asserts the magic number — it fails with a loudENOENTif a font file goes missing, which is the right failure mode: deterministic, at build time, naming the file. Verified by deleting a font and watching it fail.bun run type-checkclean; landing suite 6/6.Checklist