Skip to content

improvement(forking): widen the fork mapping target picker and make it searchable - #6381

Merged
waleedlatif1 merged 2 commits into
stagingfrom
worktree-workflow-mapping-selector
Aug 7, 2026
Merged

improvement(forking): widen the fork mapping target picker and make it searchable#6381
waleedlatif1 merged 2 commits into
stagingfrom
worktree-workflow-mapping-selector

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Widen the fork-sync mapping target picker from 240px to 320px so long secret keys stop clipping to SLACK_PUX_SANDBOX_KB_… — two same-prefixed keys were indistinguishable in the list
  • Turn on searchable for that picker so you can type to filter targets instead of scrolling
  • Search also makes the pre-existing "More options than shown — search by name" hint actionable; it appears once a workspace passes CANDIDATE_LIMIT, but there was no search box to do it in

No emcn changes — ChipCombobox is already the searchable picker (ChipDropdown is the no-search one), and searchable is an existing prop used at 55 other call sites. The width constant is shared with the webhook trigger-URL rows so both stay one aligned column.

Trade-off: the label column goes 464px → 384px, so long names clip slightly sooner on the left. Right-side ambiguity was the reported bug.

Type of Change

  • Bug fix

Testing

Tested manually — tsc --noEmit, biome, and the 502 workspace-forking tests pass. Note those tests cover the fork-sync logic layer only; nothing renders fork-sync-view.tsx, so the visual change is unverified by tests.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 7, 2026 6:01pm

Request Review

@cursor

cursor Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only tweaks in fork-sync mapping (fork-sync-view.tsx) using existing ChipCombobox props; no sync logic or API changes.

Overview
Widens the shared mapping / trigger URL target column from 240px → 320px so long secret-key labels in the fork-sync mapping picker are less likely to clip to the same prefix, and turns on ChipCombobox search (searchable, Search targets) on that mapping target picker so users can filter the listed candidates.

The truncated-candidates note is updated to say search only filters targets already shown in the list (not the full candidate set behind CANDIDATE_LIMIT). Trigger URL rows keep the wider column for alignment but do not get search in this change.

Reviewed by Cursor Bugbot for commit f3158e1. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR improves the fork-sync mapping target picker and corrects the truncation guidance.

  • Widens the shared target-picker column from 240px to 320px.
  • Enables client-side target searching with a dedicated placeholder.
  • Clarifies that searching covers only the candidates included in the capped list.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/ee/workspace-forking/components/fork-sync/fork-sync-view.tsx Widens the mapping picker, enables filtering over supplied candidates, and accurately clarifies the existing candidate-cap limitation.

Reviews (2): Last reviewed commit: "fix(forking): stop the truncated-candida..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 force-pushed the worktree-workflow-mapping-selector branch from 527a243 to f3158e1 Compare August 7, 2026 18:01
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f3158e1. Configure here.

@waleedlatif1
waleedlatif1 merged commit a7080d5 into staging Aug 7, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the worktree-workflow-mapping-selector branch August 7, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant