fix(tools): align private provenance with wire payloads - #6325
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Table row provenance skips Internal tool transport rebuilds unsafe private responses by preserving the upstream HTTP 4xx–5xx status with a generic failure message (no leaked route bodies/headers); other statuses become 502 with a metadata verification error. Tests cover table/memory error paths and registry behavior when provenance crosses workspace but not user. Reviewed by Cursor Bugbot for commit 6ab405d. Configure here. |
Greptile SummaryThe PR aligns table-row secret provenance selections with JSON wire serialization and hardens handling of unverifiable private tool responses.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified. The table provenance keys now follow the serialized payload, and unverifiable private responses retain useful error status information without exposing their original bodies or headers.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/secret-provenance-selection.ts | Filters undefined top-level row properties so provenance selection keys match properties retained by JSON serialization. |
| apps/sim/lib/table/secret-provenance-selection.test.ts | Covers direct undefined filtering and end-to-end alignment with the prepared request body. |
| apps/sim/tools/index.ts | Rebuilds unverifiable private responses with a contained JSON error while retaining only valid HTTP error statuses. |
| apps/sim/tools/index.test.ts | Verifies status preservation, body and header containment, and fallback handling for non-error statuses. |
Reviews (1): Last reviewed commit: "fix(tools): align private provenance wit..." | Re-trigger Greptile
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6ab405d. Configure here.
Summary
Align private provenance with wire payloads to fix table tools errors with json structures. Edit ownership/signing to align with platform policy.
Type of Change
Testing
Tested manually
Checklist