Skip to content

improvement(tables): raise the max column limit to 1000 - #6295

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
feat/table-max-column
Aug 5, 2026
Merged

improvement(tables): raise the max column limit to 1000#6295
TheodoreSpeaks merged 1 commit into
stagingfrom
feat/table-max-column

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Raise TABLE_LIMITS.MAX_COLUMNS_PER_TABLE from 50 to 1000
  • Every enforcement site already derives from this constant — schema validation, single add-column, bulk column additions, workflow output columns, and the boundary contract — so no other change is needed
  • Row size is still bounded independently by MAX_ROW_SIZE_BYTES (400KB) and queries by MAX_QUERY_RESULT_BYTES; rows are stored as jsonb with no per-column index, so wider schemas add no DDL cost

Type of Change

  • Improvement

Testing

  • apps/sim/lib/table/__tests__/validation.test.ts — 68 passed (the max-columns case derives its fixture from the constant)
  • bun run lint clean (9 pre-existing warnings in zoho-desk.test.ts, untouched here)
  • Full audit suite passed: check:boundaries, check:api-validation:strict, check:utils, check:zustand-v5, check:react-query, check:client-boundary, check:bare-icons, check:icon-paths, check:realtime-prune, skills:check, agent-stream-docs:check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Bumps TABLE_LIMITS.MAX_COLUMNS_PER_TABLE from 50 to 1000. Every validation site (schema validation, add-column, bulk add, workflow output columns, and the boundary contract) already derives from this constant.
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 5, 2026 8:36pm

Request Review

@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single numeric limit change with no auth or data-model changes; remaining row and query byte limits still constrain wide schemas.

Overview
Raises TABLE_LIMITS.MAX_COLUMNS_PER_TABLE from 50 to 1000 in constants.ts.

Schema validation, API contracts (createTableBodySchema), add-column and bulk column paths, and related tests all read this constant, so the new cap applies everywhere without further edits. Row size (MAX_ROW_SIZE_BYTES) and query result size limits still bound payload size independently; rows stay jsonb without per-column DDL.

Reviewed by Cursor Bugbot for commit 0d6550a. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR raises the shared maximum number of columns per table from 50 to 1000.

  • Updates the central table-limit constant used by existing validation and column-creation paths.
  • Leaves the independent row-size and query-result limits unchanged.

Confidence Score: 5/5

The PR appears safe to merge, with the previously acknowledged wide-grid performance concern remaining non-blocking.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/lib/table/constants.ts Raises MAX_COLUMNS_PER_TABLE from 50 to 1000, expanding the shared validation boundary without changing its enforcement structure.

Reviews (2): Last reviewed commit: "improvement(tables): raise the max colum..." | Re-trigger Greptile

Comment thread apps/sim/lib/table/constants.ts
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0d6550a. Configure here.

@TheodoreSpeaks
TheodoreSpeaks merged commit 2172558 into staging Aug 5, 2026
30 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the feat/table-max-column branch August 5, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant