fix(jira): add classic JSM scopes to close granular scope-set gap#5005
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview The Jira OAuth provider now includes classic JSM scopes ( The JSM knowledge connector now requires Atlassian service-account docs list the JSM classic minimum scopes, rename Jira to “classic,” and add a warning to prefer classic scopes over partial granular sets. Reviewed by Cursor Bugbot for commit d318ab8. Configure here. |
Greptile SummaryThis PR closes a scope-gap in the Jira OAuth provider by adding three classic JSM scopes (
Confidence Score: 5/5Safe to merge once the Atlassian developer console app has the three classic JSM scopes enabled, as noted in the deploy instructions. The changes are narrowly scoped to adding OAuth scopes, updating their display names, and aligning the knowledge connector's required-scope gate with the new classic scope. The intentional reconnect prompt for stale credentials is clearly motivated by the comment. No logic paths are altered; the only runtime effect on existing users is a reconnect prompt for JSM connector credentials that lack No files require special attention beyond the deploy-time prerequisite of enabling the new scopes in the Atlassian developer console before this ships to production. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Sim
participant AtlassianOAuth as Atlassian OAuth
participant JSMAPI as JSM API
User->>Sim: Connect Jira (OAuth)
Sim->>AtlassianOAuth: Request scopes (classic + granular)
Note over AtlassianOAuth: read:servicedesk-request, write:servicedesk-request, manage:servicedesk-customer, read:user:jira now included
AtlassianOAuth-->>Sim: Token with all scopes granted
Sim->>JSMAPI: GET /request
Note over JSMAPI: Classic scope satisfies endpoint
JSMAPI-->>Sim: 200 OK
Note over Sim: Stale credential check
Sim->>Sim: requiredScopes check (read:servicedesk-request missing)
Sim-->>User: Reconnect prompt surfaced
Reviews (2): Last reviewed commit: "fix(jira): note read:user:jira requireme..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1b6e122. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d318ab8. Configure here.
Summary
read:servicedesk-request,write:servicedesk-request,manage:servicedesk-customer) and granularread:user:jirato the Jira OAuth provider scope listread:user:jirain their granular sets, so tokens built from our granular-only list failed withUnauthorized; scope does not matcheven though every individual scope was granted; each classic scope authorizes its endpoints standaloneread:servicedesk-requeston the JSM knowledge connector so stale credentials surface a reconnect prompt instead of failing mid-syncType of Change
Testing
Audited every Jira/JSM tool endpoint against Atlassian's API docs to confirm each operation now has a fully satisfied scope path (classic or complete granular). The classic-scope fix is verified against a live JSM instance. oauth/blocks/connector test suites pass (347 tests);
check:api-validationpasses.Note for deploy: the Atlassian developer console app must have all four new scopes enabled before this reaches production — the three classic JSM scopes (
read:servicedesk-request,write:servicedesk-request,manage:servicedesk-customer) and the granularread:user:jira, or new Jira connections will fail at the consent screen. Existing connections are unaffected either way (no execution-time scope gate; refresh preserves the original grant).Checklist