fix(helm): allow host[:port][/path] form in global.imageRegistry schema#4686
Conversation
The values.schema.json constrained global.imageRegistry to JSON Schema hostname format (RFC 1123), which forbids '/'. That rejected the host+path form required by Artifactory virtual repos, Harbor projects, GCR (gcr.io/project-id), and ECR-with-namespace — all of which the chart's image-rendering helper already supports (it prints '%s/%s:%s'). Drop the format constraint and document the supported shapes. Matches the bitnami common-chart convention of validating image registry as a plain string and deferring to Docker for the actual reference parse.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview This unblocks Reviewed by Cursor Bugbot for commit 05c2e19. Configure here. |
Greptile SummaryThis PR removes
Confidence Score: 5/5Safe to merge — single-line schema constraint removal with no runtime logic changes. The change removes one overly strict format keyword from a single JSON Schema field and replaces it with a more descriptive string. The template logic that consumes imageRegistry is unchanged, and the fix correctly aligns schema validation with what Docker's image reference parser already accepts. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["helm install / helm upgrade"] --> B["values.schema.json validation"]
B --> C{{"global.imageRegistry set?"}}
C -- "No" --> D["Use default (no registry prefix)"]
C -- "Yes" --> E{{"Before this PR: format: hostname check"}}
E -- "host only (registry.example.com)" --> F["✅ Passes"]
E -- "host/path (gcr.io/project-id)" --> G["❌ Rejected — / not allowed by RFC 1123"]
C -- "Yes" --> H{{"After this PR: type: string only"}}
H -- "host only" --> I["✅ Passes"]
H -- "host:port" --> J["✅ Passes"]
H -- "host/path" --> K["✅ Passes"]
F --> L["_helpers.tpl renders: registry/repository:tag"]
I --> L
J --> L
K --> L
Reviews (1): Last reviewed commit: "fix(helm): allow host[:port][/path] form..." | Re-trigger Greptile |
Summary
Type of Change
Checklist