Skip to content

Disables the icelake kernel when building with Visual Studio 2019. - #328

Merged
lemire merged 4 commits into
masterfrom
node_windows2019_bug
Oct 9, 2023
Merged

lemire merged 4 commits into
masterfrom
node_windows2019_bug

Conversation

@lemire

@lemire lemire commented Oct 8, 2023 •

Copy link
Copy Markdown
Member

This patch disables the icelake kernel when building with Visual Studio 2019.

@deepak1556 demonstrated an issue that we reproduce solely with Visual Studio 2019 (not Visual Studio 2022) when transcoding from UTF-16 to UTF-8 using AVX-512 routines. It seems possible that the AVX-512 support in Visual Studio 2019 is faulty.

Fixes #329

@lemire lemire changed the title Adding test for Visual Studio 2019 issue in node Disables the icelake kernel when building with Visual Studio 2019. Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider disabling the icelake kernel for Visual Studio 2019

1 participant