CLDSRV-884: Backport OpenTelemetry tracing instrumentation - #6294
BourgoisMickael wants to merge 4 commits into
Conversation
+ update yarn.lock after cherry-pick Issue: CLDSRV-884 (cherry picked from commit a6f74d3)
Keep functions not async but return the Promise for tests Issue: CLDSRV-884 (cherry picked from commit 0f86bf9)
Issue: CLDSRV-884 (cherry picked from commit b16b268)
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## development/9.3 #6294 +/- ##
===================================================
- Coverage 85.32% 85.26% -0.06%
===================================================
Files 206 206
Lines 13435 13440 +5
===================================================
- Hits 11463 11460 -3
- Misses 1972 1980 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
francoisferrand
left a comment
There was a problem hiding this comment.
I really don't think we should do this : this is basically re-creating the situation of Cloudserver 7 (i.e. sticking to an old branch instead of upgrading)...
- We should move forward instead, and finish integrating (or fixing if needed) 9.4.
- Performance testing could probably be done with a "patched" S3C version, running cloudserver 9.5.
- Backporting always creates a risk, and which is exactly what we try to protect against when we create a branch: Cloudserver 9.3 is shipping already in Artesca, and we don't want to take the risk of introducing (major) feature through a patch release
|
@francoisferrand we won't merge this. Using it just for the image, I'm closing the PR. |
Cherry-pick #6140
S3C 10.1 with cloudserver 9.4 is not ready to be used yet so I backport tracing to be used in S3C 9.5 and 10.0.
Changes from cherry-pick: