Fix lp2 builds#12
Merged
Merged
Conversation
brunoro
approved these changes
Apr 25, 2025
brunoro
left a comment
brunoro
left a comment
There was a problem hiding this comment.
LGTM and LightOS built fine locally on both LP2 and LP3 flavors.
Just pointing the dependency to the repo will not work because the actual package contents is inside this package folder.
In order to QA it I had to replace the contents in the LightOS/node_modules/react-native-vision-camera folder with the stuff in the package folder of this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This fixes the problem we were seeing for lp2 builds failing because we were importing the lp3.jar files in this repo as part of the EIS fix.
Changes
Tested on
Related issues