Repository navigation
Conversation
The imports of LogEntryType in test_raft_service.py had a bare `# noqa`. The name is used, so no unused-import check applies. The only rule that reports these lines is PLC0415 (import not at the top of the file), which is not enabled. Remove the comments. Refs saltstack#70367.
charzl
force-pushed
the
cleanup/blanket-noqa-raft-test
branch
from
November 19, 2026 19:10
fdd3a0f to
afe9ad9
Compare
twangboy
approved these changes
Nov 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes two bare
# noqacomments intests/pytests/functional/cluster/consensus/test_raft_service.py. Found by the Ruff checks from #70367 (PGH004).A bare
# noqahides every Ruff message on the line, so it also hides new ones. These two do not hide anything useful:LogEntryTypeis used a few lines later, so there is no unused import. I ran Ruff with--ignore-noqaon the two lines. The only rule that reports them, other thanPGH004itself, isPLC0415(an import that is not at the top of the file). That rule is not enabled, and the matching pylint check (import-outside-toplevel) is disabled in.pylintrc. The other two imports ofLogEntryTypein the same file already have nonoqa.What issues does this PR fix or reference?
Refs #70367.
Previous Behavior / New Behavior
No change.
Testing
Only comments change. Ruff with the repository configuration reports nothing for the file, and the file still collects (51 tests).
Merge requirements satisfied?
Commits signed with GPG?
No