feat: validate-pr workflow now enforces proper commit formatting @W-23251216@#162
Open
jfeingold35 wants to merge 15 commits into
Open
feat: validate-pr workflow now enforces proper commit formatting @W-23251216@#162jfeingold35 wants to merge 15 commits into
jfeingold35 wants to merge 15 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
validate-prworkflow only checked that a Pull Request's title and body both contained a string that looked like it could conceivably be a GUS work item (i.e.,W-\d{7,8}in title, and@W-\d{7,8}@in body).Now, the workflow enforces multiple things:
<type> (<optional-scope>): <description> (W-XXXXXXX)where
<type>is one of:feat|fix|docs|style|refactor|perf|test|build|ci|chore|revertThis enhancement was done for @W-23251216@.
(all of the testing I did against this was done using this PR in
testPackageRelease, and you can check the action execution history here to see me finally get to ones that work properly.