Skip to content

Strongly typed strides #283

Open
Open

Description

@bluss
  • Separate type for D: Dimension and its corresponding stride
  • Strides are signed integers (isize)

Activity

  1. self-assigned this
    on Mar 25, 2017
  2. Robbepop commented on Mar 28, 2017

    @Robbepop

    I like this refactoring!
    Personally I was slightly confused about this when scanning through the source code of ndarray.

  3. bluss commented on Mar 28, 2017

    @bluss
    MemberAuthor

    It does keep it simple, less generics noise and repetition. However it is time..

  4. bluss commented on Apr 9, 2017

    @bluss
    MemberAuthor

    Postponed to after 0.9. Potentially we want a bigger reorganization of Dimensions

  5. Robbepop commented on Apr 9, 2017

    @Robbepop

    Good decision - 0.9 is already pretty big!

  6. bluss commented on Apr 9, 2017

    @bluss
    MemberAuthor

    Yeah; I don't know how I found so many technically breaking changes to add. There will always be intensive and not so intensive periods.

  7. Robbepop commented on Apr 9, 2017

    @Robbepop

    Yes, but I personally really like the way you handle refactoring of code and breaking changes in your projects. You do not fear them, you approach them and simply introduce all those new shiny features instead of going with an overly conservative approach that avoids to ever break anything which sadly is a strategy in a few crates ... 👍
    But who am I to judge. ;)

  8. bluss commented on Apr 10, 2017

    @bluss
    MemberAuthor

    In this case they have been many technically breaking but almost no actual effect on end users. All changes are judged for their effect, not the technically breaking status. Which is why it is hard to change how dimensions work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions