Repository navigation
Conversation
`struct itimerval` was bound but `getitimer`, `setitimer` and the `ITIMER_*` constants were not. Add them, `strptime`, and the `CLOCK_VIRTUAL`, `CLOCK_HIGHRES` and `CLOCK_PROF` clock ids that the existing comment already mentions. The C11/C23 `timespec_get`/`timespec_getres` and their `TIME_*` bases are illumos additions (`ILLUMOS_0.20`/`ILLUMOS_0.52`) and go in the illumos module. sys/time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/uts/common/sys/time.h#L199-L212 sys/time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/uts/common/sys/time.h#L402-L410 sys/time_impl.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/uts/common/sys/time_impl.h#L120-L134 time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/time.h#L105-L106 time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/time.h#L306-L316
Collaborator
Member
|
Rewrite commit messages and PR descriptions by hand, then you may unmark as a draft. See https://forge.rust-lang.org/policies/llm-usage.html#-banned. |
tgross35
marked this pull request as draft
November 5, 2026 22:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct itimervalwas bound butgetitimer,setitimerand theITIMER_*constants were not. Add them,strptime, and theCLOCK_VIRTUAL,CLOCK_HIGHRESandCLOCK_PROFclock ids that theexisting comment already mentions.
The C11/C23
timespec_get/timespec_getresand theirTIME_*basesare illumos additions (
ILLUMOS_0.20/ILLUMOS_0.52) and go in theillumos module.
sys/time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/uts/common/sys/time.h#L199-L212
sys/time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/uts/common/sys/time.h#L402-L410
sys/time_impl.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/uts/common/sys/time_impl.h#L120-L134
time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/time.h#L105-L106
time.h: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/time.h#L306-L316
Testing
cargo checkforx86_64-unknown-illumos,aarch64-unknown-illumos,x86_64-pc-solarisandsparcv9-sun-solaris(with-Dwarnings).libc-test/semverlists compiles forillumos and Solaris; new constant values were cross-checked
mechanically against the illumos-gate headers.
ci/style.pychecks (rustfmt, sorted/unique semver lists, style test).CC=clang cargo test -p libc-teston OmniOS r151060 (x86_64): passes@rustbot label stable-nominated
🤖 Generated with Claude Code
https://claude.ai/code/session_01PUjq5rfL3s7TbKS3PeAE5K