Skip to content

solarish: add missing getaddrinfo flags and error codes - #5702

Draft
extrowerk wants to merge 1 commit into
rust-lang:mainfrom
extrowerk:illumos-netdb-ai-flags
Draft

extrowerk wants to merge 1 commit into
rust-lang:mainfrom
extrowerk:illumos-netdb-ai-flags

Conversation

@extrowerk

Copy link
Copy Markdown

AI_CANONNAME was the only ai_flags value bound, so AI_PASSIVE,
AI_NUMERICHOST and friends had to be hard-coded by users on illumos and
Solaris. Add the rest of the addrinfo flags, the two missing EAI_*
error codes and MAXHOSTNAMELEN, all from <netdb.h>.

These values are inherited unchanged from OpenSolaris and are part of the
binary ABI on both illumos and Solaris.

Source: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/netdb.h#L131-L163
Source: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/netdb.h#L394
Manual: https://illumos.org/man/3SOCKET/getaddrinfo

Testing

  • cargo check for x86_64-unknown-illumos, aarch64-unknown-illumos,
    x86_64-pc-solaris and sparcv9-sun-solaris (with -Dwarnings).
  • Every name in the applicable libc-test/semver lists compiles for
    illumos and Solaris; new constant values were cross-checked
    mechanically against the illumos-gate headers.
  • ci/style.py checks (rustfmt, sorted/unique semver lists, style test).
  • CC=clang cargo test -p libc-test on OmniOS r151060 (x86_64): passes

@rustbot label stable-nominated

🤖 Generated with Claude Code

https://claude.ai/code/session_01PUjq5rfL3s7TbKS3PeAE5K

`AI_CANONNAME` was the only `ai_flags` value bound, so `AI_PASSIVE`,
`AI_NUMERICHOST` and friends had to be hard-coded by users on illumos and
Solaris. Add the rest of the `addrinfo` flags, the two missing `EAI_*`
error codes and `MAXHOSTNAMELEN`, all from `<netdb.h>`.

These values are inherited unchanged from OpenSolaris and are part of the
binary ABI on both illumos and Solaris.

Source: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/netdb.h#L131-L163
Source: https://github.com/illumos/illumos-gate/blob/b56614870515295c253babb2b10fffdd3c60fdbe/usr/src/head/netdb.h#L394
Manual: https://illumos.org/man/3SOCKET/getaddrinfo
@rustbot

rustbot commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in a solarish module

cc @jclulow, @pfmooney

@rustbot rustbot added O-solarish O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 5, 2026
@tgross35

tgross35 commented Nov 5, 2026

Copy link
Copy Markdown
Member

Rewrite commit messages and PR descriptions by hand, then you may unmark as a draft. See https://forge.rust-lang.org/policies/llm-usage.html#-banned.

@tgross35
tgross35 marked this pull request as draft November 5, 2026 22:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-solarish O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants