Repository navigation
Conversation
`libc-test/semver/solarish.txt` lists API shared by illumos and Solaris, but `do_semver` only reads files named after the target family, vendor, OS, arch and env. Neither illumos (`x86_64-unknown-illumos`) nor Solaris (`x86_64-pc-solaris`, `sparcv9-sun-solaris`) has `solarish` as any of those, so the list was never checked. Read `solarish.txt` for both OSes. The semver test imports every list into one module, so entries that appear twice are an error; drop the two entries that are already in `unix.txt` (`IP_TTL`, `bind`) and the `exec*`/`fork`/`system` entries that `illumos.txt` duplicates from `solarish.txt`.
Collaborator
Member
|
Rewrite commit messages and PR descriptions by hand, then you may unmark as a draft. See https://forge.rust-lang.org/policies/llm-usage.html#-banned. |
tgross35
marked this pull request as draft
November 5, 2026 22:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libc-test/semver/solarish.txtlists API shared by illumos and Solaris,but
do_semveronly reads files named after the target family, vendor,OS, arch and env. Neither illumos (
x86_64-unknown-illumos) nor Solaris(
x86_64-pc-solaris,sparcv9-sun-solaris) hassolarishas any ofthose, so the list was never checked.
Read
solarish.txtfor both OSes. The semver test imports every listinto one module, so entries that appear twice are an error; drop the two
entries that are already in
unix.txt(IP_TTL,bind) and theexec*/fork/systementries thatillumos.txtduplicates fromsolarish.txt.Testing
cargo checkforx86_64-unknown-illumos,aarch64-unknown-illumos,x86_64-pc-solarisandsparcv9-sun-solaris(with-Dwarnings).libc-test/semverlists compiles forillumos and Solaris; new constant values were cross-checked
mechanically against the illumos-gate headers.
ci/style.pychecks (rustfmt, sorted/unique semver lists, style test).CC=clang cargo test -p libc-teston OmniOS r151060 (x86_64): passes@rustbot label stable-nominated
🤖 Generated with Claude Code
https://claude.ai/code/session_01PUjq5rfL3s7TbKS3PeAE5K