Skip to content

libc-test: check solarish.txt in the semver test - #5700

Draft
extrowerk wants to merge 1 commit into
rust-lang:mainfrom
extrowerk:illumos-semver-solarish
Draft

extrowerk wants to merge 1 commit into
rust-lang:mainfrom
extrowerk:illumos-semver-solarish

Conversation

@extrowerk

Copy link
Copy Markdown

libc-test/semver/solarish.txt lists API shared by illumos and Solaris,
but do_semver only reads files named after the target family, vendor,
OS, arch and env. Neither illumos (x86_64-unknown-illumos) nor Solaris
(x86_64-pc-solaris, sparcv9-sun-solaris) has solarish as any of
those, so the list was never checked.

Read solarish.txt for both OSes. The semver test imports every list
into one module, so entries that appear twice are an error; drop the two
entries that are already in unix.txt (IP_TTL, bind) and the
exec*/fork/system entries that illumos.txt duplicates from
solarish.txt.

Testing

  • cargo check for x86_64-unknown-illumos, aarch64-unknown-illumos,
    x86_64-pc-solaris and sparcv9-sun-solaris (with -Dwarnings).
  • Every name in the applicable libc-test/semver lists compiles for
    illumos and Solaris; new constant values were cross-checked
    mechanically against the illumos-gate headers.
  • ci/style.py checks (rustfmt, sorted/unique semver lists, style test).
  • CC=clang cargo test -p libc-test on OmniOS r151060 (x86_64): passes

@rustbot label stable-nominated

🤖 Generated with Claude Code

https://claude.ai/code/session_01PUjq5rfL3s7TbKS3PeAE5K

`libc-test/semver/solarish.txt` lists API shared by illumos and Solaris,
but `do_semver` only reads files named after the target family, vendor,
OS, arch and env. Neither illumos (`x86_64-unknown-illumos`) nor Solaris
(`x86_64-pc-solaris`, `sparcv9-sun-solaris`) has `solarish` as any of
those, so the list was never checked.

Read `solarish.txt` for both OSes. The semver test imports every list
into one module, so entries that appear twice are an error; drop the two
entries that are already in `unix.txt` (`IP_TTL`, `bind`) and the
`exec*`/`fork`/`system` entries that `illumos.txt` duplicates from
`solarish.txt`.
@rustbot

rustbot commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in a solarish module

cc @jclulow, @pfmooney

@rustbot rustbot added O-illumos O-solarish S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 5, 2026
@tgross35

tgross35 commented Nov 5, 2026

Copy link
Copy Markdown
Member

Rewrite commit messages and PR descriptions by hand, then you may unmark as a draft. See https://forge.rust-lang.org/policies/llm-usage.html#-banned.

@tgross35
tgross35 marked this pull request as draft November 5, 2026 22:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-illumos O-solarish stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants