Skip to content

fix(kubernetes): preserve proxy URL for exec sessions - #1

Merged
russellb merged 1 commit into
russellb:feat/kubernetes-proxy-pod-topologyfrom
jhjaggars:fix-proxy-pod-exec-env/jhjaggars
Sep 2, 2026
Merged

fix(kubernetes): preserve proxy URL for exec sessions#1
russellb merged 1 commit into
russellb:feat/kubernetes-proxy-pod-topologyfrom
jhjaggars:fix-proxy-pod-exec-env/jhjaggars

Conversation

@jhjaggars

Copy link
Copy Markdown

Summary

Preserve the proxy-pod companion URL in OPENSHELL_PROXY_URL so commands launched through openshell sandbox exec reconstruct the standard proxy environment and can reach policy-approved destinations.

OpenShift validation of NVIDIA/OpenShell#2885 found that the agent Pod had HTTP_PROXY and HTTPS_PROXY, but relay-spawned exec processes did not. The process supervisor clears each child environment and rebuilds proxy variables from OPENSHELL_PROXY_URL; the proxy-pod transform calculated that URL but did not export it.

Related Issue

No issue required: localized bug fix found while validating NVIDIA#2885.

Changes

  • Export the proxy-pod companion URL through the canonical OPENSHELL_PROXY_URL environment variable.
  • Extend the existing proxy-pod rendering test to require both the canonical URL and HTTP_PROXY.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • mise run test passes
  • OpenShift/OVN controlled validation:
    • Before the change, exec had no HTTPS_PROXY; implicit curl timed out with exit 28.
    • Adding only OPENSHELL_PROXY_URL to the generated pod template caused exec to synthesize HTTPS_PROXY; implicit HTTPS GET returned 200.
    • Policy-denied host and method remained blocked, and --noproxy direct bypass remained fenced.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; this restores intended behavior)

Signed-off-by: Jesse Jaggars <jjaggars@redhat.com>
@russellb
russellb merged commit f9d1454 into russellb:feat/kubernetes-proxy-pod-topology Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants