Rescue error on disposeBrowserContext when context is missing#545
Closed
jvon1904 wants to merge 1 commit intorubycdp:mainfrom
Closed
Rescue error on disposeBrowserContext when context is missing#545jvon1904 wants to merge 1 commit intorubycdp:mainfrom
jvon1904 wants to merge 1 commit intorubycdp:mainfrom
Conversation
crahles
added a commit
to fuchs-eule/ferrum
that referenced
this pull request
Sep 16, 2025
Member
|
Proper fix should ignore default implicit context as in #566 |
crahles
added a commit
to fuchs-eule/ferrum
that referenced
this pull request
Apr 20, 2026
…rror Newer Chromium builds can report a "lost execution context" with the phrase "Failed to find context with id <N>" instead of the historical "Cannot find context with specified id". Match both so the error is classified as a recoverable NoExecutionContextError (the client's retry path) rather than bubbling up as a generic BrowserError. This is the client.rb half of the previously ported rubycdp#545. The contexts.rb half is dropped on rebase because upstream rubycdp#566 (56a46cd) addresses the underlying "dispose on missing context" issue with a different, preferable approach (filter browser#reset against Target.getBrowserContexts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my comments on Issue #540.