Skip to content

Remove dependency on package_protections #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexevanczuk merged 1 commit into from
Nov 8, 2022
Merged

Remove dependency on package_protections #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 1 addition & 38 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ PATH
specs:
visualize_packwerk (0.0.4)
code_ownership
package_protections
parse_packwerk
rake
ruby-graphviz
Expand All @@ -12,11 +11,6 @@ PATH
GEM
remote: https://rubygems.org/
specs:
activesupport (7.0.3.1)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
ast (2.4.2)
code_ownership (1.28.0)
code_teams (~> 1.0)
Expand All @@ -25,36 +19,23 @@ GEM
code_teams (1.0.0)
sorbet-runtime
coderay (1.1.3)
concurrent-ruby (1.1.10)
diff-lcs (1.5.0)
i18n (1.12.0)
concurrent-ruby (~> 1.0)
json (2.6.2)
method_source (1.0.0)
minitest (5.16.2)
netrc (0.11.0)
package_protections (1.3.0)
activesupport
parse_packwerk
rubocop
rubocop-sorbet
sorbet-runtime
parallel (1.22.1)
parse_packwerk (0.11.0)
parse_packwerk (0.14.0)
sorbet-runtime
parser (3.1.2.1)
ast (~> 2.4.1)
pry (0.14.1)
coderay (~> 1.1)
method_source (~> 1.0)
rainbow (3.1.1)
rake (13.0.6)
rbi (0.0.15)
ast
parser (>= 2.6.4.0)
sorbet-runtime (>= 0.5.9204)
unparser
regexp_parser (2.5.0)
rexml (3.2.5)
rspec (3.11.0)
rspec-core (~> 3.11.0)
Expand All @@ -69,23 +50,8 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.11.0)
rspec-support (3.11.0)
rubocop (1.35.0)
json (~> 2.3)
parallel (~> 1.10)
parser (>= 3.1.2.1)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.20.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.21.0)
parser (>= 3.1.1.0)
rubocop-sorbet (0.6.11)
rubocop (>= 0.90.0)
ruby-graphviz (1.2.5)
rexml
ruby-progressbar (1.11.0)
sorbet (0.5.10323)
sorbet-static (= 0.5.10323)
sorbet-runtime (0.5.10323)
Expand All @@ -109,9 +75,6 @@ GEM
thor (>= 1.2.0)
yard-sorbet
thor (1.2.1)
tzinfo (2.0.5)
concurrent-ruby (~> 1.0)
unicode-display_width (2.2.0)
unparser (0.6.5)
diff-lcs (~> 1.3)
parser (>= 3.1.0)
Expand Down
1 change: 0 additions & 1 deletion lib/visualize_packwerk.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ module VisualizePackwerk
require 'visualize_packwerk/railtie' if defined?(Rails)
require 'parse_packwerk'
require 'code_ownership'
require 'package_protections'
require 'graphviz'

require 'visualize_packwerk/node_interface'
Expand Down
2 changes: 1 addition & 1 deletion lib/visualize_packwerk/package_graph.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def self.construct
# We would also need to ignore it when parsing PackageNodes.
# next if p.name == ParsePackwerk::ROOT_PACKAGE_NAME
owner = CodeOwnership.for_package(p)
violations_by_package = PackageProtections::ProtectedPackage.from(p).violations.group_by(&:to_package_name).transform_values(&:count)
violations_by_package = p.violations.group_by(&:to_package_name).transform_values(&:count)

package_nodes << PackageNode.new(
name: p.name,
Expand Down
Loading