Repository navigation
Add missing core instance methods - #3220
Merged
Merged
Conversation
Add signatures for public instance methods that are defined in Ruby 4.0 but were missing from core/: - Binding#implicit_parameter_defined?, #implicit_parameter_get, #implicit_parameters - IO#external_encoding, IO#to_path, IO#wait_priority - Process::Tms#utime, #stime, #cutime, #cstime and their setters - Thread#set_trace_func
ksss
reviewed
Oct 11, 2026
| # Establishes *proc* on *thr* as the handler for tracing, or disables tracing if | ||
| # the parameter is `nil`. | ||
| # | ||
| # See Kernel#set_trace_func. |
Collaborator
There was a problem hiding this comment.
How about adding Kernel#set_trace_func as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds signatures for public C-defined instance methods of Ruby 4.0 that had no signature in
core/. Doc comments are generated byrbs annotatefrom the RDoc of v4.0.7.Binding#implicit_parameter_defined?bind_implicit_parameter_defined_pBinding#implicit_parameter_getbind_implicit_parameter_getBinding#implicit_parametersbind_implicit_parametersIO#external_encodingnilfor a write stream without an encodingrb_io_external_encodingIO#to_path#pathrb_io_pathIO#wait_priority#wait_readableio_wait_priorityProcess::Tms#cstimeProcess::Tms#cstime=Process::Tms#cutimeProcess::Tms#cutime=Process::Tms#stimeProcess::Tms#stime=Process::Tms#utimeProcess::Tms#utime=Thread#set_trace_functhread_set_trace_func_mThe
Process::Tmsaccessors are Struct members created byrb_struct_define_underat process.c#L9606.Not covered: the remaining
IO::Bufferinstance methods (#each,#values, …) andMethod#box.