Repository navigation
Conversation
Comments between the first and the last statement of a class/module body were treated as enclosed in the body `StatementsNode`, and reported as unused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3175
Summary
Instance variable annotations written between class/module members were reported as unused. Only the ones before the first member or after the last member worked.
Why
visit_class_or_module_bodyreports comments enclosed in the child nodes of the class/module node as unused. The body is a singleStatementsNodespanning from the first statement to the last one, so every comment between statements was treated as enclosed. This change looks into each statement of the body instead.A class body with
rescue/ensure(BeginNode) is left as before.Also added a note to
docs/inline.mdthat the declarations need a blank line before the following member, since a comment block directly above adef/attr_*belongs to that member.🤖 Generated with Claude Code