Merged
Conversation
Fix rounding of VpDivd with one: VpDivd can't use VpAsgn which rounds with the current rounding mode. Fix VpDivd loop bug that sometimes skip calculating last DECDIG.
Member
Author
|
I want to add a test for VpDivd, but the current VpDivd calculation is weird. VpDivd(c, r, a, b);
c->frac[0] // This value is always zero.I'll add a test in a separate pull request with VpDivd fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix VpDivd bug which is a blocker of #371.
Fix rounding: VpDivd should always truncate. Remove wrong optimization that uses VpAsgn which rounds with the current rounding mode.
Fix VpDivd loop bug that sometimes skip calculating last DECDIG.