Update bigdecimal.c to fix issue with installation on macOS#307
Closed
mkyloa wants to merge 1 commit intoruby:masterfrom
Closed
Update bigdecimal.c to fix issue with installation on macOS#307mkyloa wants to merge 1 commit intoruby:masterfrom
mkyloa wants to merge 1 commit intoruby:masterfrom
Conversation
Update bigdecimal.c to fix issue with installation on macOS
Contributor
|
Perhaps this is trying to repair the same thing as #306? |
Member
|
@mkyloa Could you please describe what errors you encountered? I couldn't confirm there are any issues with installation on macOS. |
|
I'm noticing a similar error installing 2.X releases on OSX. I took this PR and built the gem locally. Installation seemed to work ok. Would appreciate a back port of this :-) OSX VersionGem Env:Installation Log: Just updating the version to get a local build: Building and installing gem locally: Testing in irb: related: #304 |
Member
|
Several lines around the changed line will be removed in #391. - /* MACRO's to guard objects from GC by keeping them in stack */
- #ifdef RBIMPL_ATTR_MAYBE_UNUSED
- #define ENTER(n) RBIMPL_ATTR_MAYBE_UNUSED() volatile VALUE vStack[n];int iStack=0
- #else
- #define ENTER(n) volatile VALUE RB_UNUSED_VAR(vStack[n]);int iStack=0
- #endif
- #define PUSH(x) (vStack[iStack++] = (VALUE)(x))
- #define GUARD_OBJ(p, y) ((p)=(y), PUSH((p).bigdecimal)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update bigdecimal.c to fix issue with installation on macOS