Skip to content

Update gorp dependency to gorp.v2 #205

Open

Description

@jamesatwill-okta

Hi! Could I convince you to migrate from gorp.v1 to gorp.v2?

There's only one note in the migration guide: https://github.com/go-gorp/gorp#pre-v2-to-v2

Activity

  1. rubenv commented on Jan 27, 2022

    @rubenv
    Owner

    It's probably about time we do that indeed!

    Could you send a PR?

  2. idcmp commented on Jan 27, 2022

    @idcmp
    Contributor

    #206 bumps to the latest gorp which is backwards compatible with v2.2.0 except it cleans up its go.mod handling. HTH!

  3. rubenv commented on Jan 28, 2022

    @rubenv
    Owner

    Closed in #206, thanks @idcmp

  4. wonsikin commented on Jan 31, 2022

    @wonsikin

    @jamesatwill-okta @rubenv
    Found an issue after #206 was merged

    $ go get -v github.com/rubenv/sql-migrate/...
    github.com/rubenv/sql-migrate (download)
    github.com/go-gorp/gorp (download)
    package github.com/rubenv/sql-migrate: cannot find package "github.com/go-gorp/gorp/v3" in any of:
    	/usr/local/go/src/github.com/go-gorp/gorp/v3 (from $GOROOT)
    	/go/src/github.com/go-gorp/gorp/v3 (from $GOPATH)
  5. slee500 commented on Jan 31, 2022

    @slee500

    @wonsikin Had the same error too. If you do export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/... this fixes the issue.

  6. joj0hq commented on Jan 31, 2022

    @joj0hq

    @slee500 @wonsikin
    I did export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/....
    But I had same error too.
    My Golang version is 1.15.0.

  7. joj0hq commented on Feb 1, 2022

    @joj0hq

    I'm sorry. I had mistake.
    If you do export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/... this fixes the issue.
    But I don't know this reason.

  8. slee500 commented on Feb 15, 2022

    @slee500

    @jotaro-biz here's a good writeup on what export GO111MODULE=on does.
    https://maelvls.dev/go111module-everywhere/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions